[🐛 Bug]: [dotnet] [bidi] Screenshot bytes pointed to the cashed bytes?

[nvborisenko]

Description

Is it good to use ReadonlyMemory<byte>?

Reproducible Code

var screenshot1 = bidi.GetScreenshot();

driver.URL = "https://goole.com";

var screenshot2 = bidi.GetScreenshot();


Interesting whether `screenshot1` and `screenshot2` is the same.

[selenium-ci]

@nvborisenko, thank you for creating this issue. We will troubleshoot it as soon as we can.

Selenium Triage Team: remember to follow the Triage Guide

[nvborisenko]

selenium/dotnet/src/webdriver/BiDi/BrowsingContext/CaptureScreenshotCommand.cs

Line 62 in d6ed112

public sealed record CaptureScreenshotResult(ReadOnlyMemory<byte> Data) : EmptyResult

As I understand it captures a range of bytes already allocated in memory. It might be risky, given that broker might reuse memory while listening incoming WebSocket messages. Just doble check please.

[nvborisenko]

It is safe, STJ allocates new bytes when deserializing from base64 string.