Skip to content

Conversation

@TamsilAmani
Copy link
Contributor

@TamsilAmani TamsilAmani commented Jun 19, 2023

Description

Add network module events and types

Motivation and Context

Implement network module events and types as described in https://w3c.github.io/webdriver-bidi/#module-network

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@TamsilAmani TamsilAmani force-pushed the rb-bidi-network-module branch 2 times, most recently from 08f6234 to b63c1dc Compare June 20, 2023 13:07
@TamsilAmani TamsilAmani marked this pull request as ready for review June 20, 2023 13:07
@TamsilAmani TamsilAmani requested a review from p0deje June 20, 2023 13:08
@TamsilAmani
Copy link
Contributor Author

TamsilAmani commented Jun 20, 2023

@p0deje @titusfortner
This time I haven't wrapped the response from the browser into any object. Giving the user response as it is. Do you agree with this approach?

In another module (Script) I have wrapped the response into custom-defined classes which I need to change as per your suggestions.
#12082

Copy link
Member

@p0deje p0deje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks great. In regards to wrapping request/response, I think we can iterate later and generalize rb/lib/selenium/webdriver/devtools/request.rb and rb/lib/selenium/webdriver/devtools/response.rb later.

@TamsilAmani TamsilAmani force-pushed the rb-bidi-network-module branch from b63c1dc to 8a9a1f0 Compare June 21, 2023 08:24
@TamsilAmani TamsilAmani force-pushed the rb-bidi-network-module branch from 8a9a1f0 to 211fd8a Compare June 21, 2023 15:06
@VietND96
Copy link
Member

VietND96 commented Nov 7, 2024

@TamsilAmani, it looks like the tests for this new function are falling. If having time, can you fix it?

@p0deje
Copy link
Member

p0deje commented Nov 11, 2024

Let's wait until #14523 is done, I guess it also implements all necessary Network commands.

@p0deje
Copy link
Member

p0deje commented Nov 11, 2024

Closing in favor if #14523

@p0deje p0deje closed this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants