Skip to content

Conversation

@nvborisenko
Copy link
Member

Description

Internal stuff should be internal.

Motivation and Context

Sometimes selenium's classes appears in IDE suggestions, and these classes are supposed to be for internal usage. Like PortUtilities class.. I don't think Selenium is created for networking.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nvborisenko nvborisenko requested a review from shs96c February 6, 2024 20:05
@diemol
Copy link
Member

diemol commented Mar 26, 2024

@nvborisenko can I merge this one? (If CI passes, of course)

@nvborisenko
Copy link
Member Author

Unfortunately no, CI will be failing. I don't know how to configure bazel, need help from @shs96c.

@nvborisenko
Copy link
Member Author

Nobody is interested in it, build system is not ready for these kind of changes. Closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants