-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[py] Fix typing in remote webdriver #14166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨
|
| def get_downloadable_files(self) -> List[str]: | ||
| """Retrieves the downloadable files as a map of file names and their | ||
| corresponding URLs.""" | ||
| corresponding URLs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to update the docstring here
|
Is this still relevant? If so, can you resolve the merge conflicts? |
fc3f165 to
d474e2f
Compare
d474e2f to
ff55efd
Compare
|
If there was anything useful in that branch, please submit another PR. |
User description
Description
The main change is changing the return type hint for
def get_downloadable_files(self)fromdicttoList[str], which is actually what is returned.Also some cosmetic improvements have been added.
Motivation and Context
I caught some error from my static type checker () and saw that

get_downloadable_fileshas the wrong type annotation and decided to fix it =)Types of changes
Checklist
PR Type
Bug fix, Enhancement
Description
get_downloadable_filesfromdicttoList[str]to accurately reflect the returned value.__exit__,get_cookie, and others to useOptionalandTypefromtyping.Changes walkthrough 📝
webdriver.py
Fix type hints and improve code formatting in `webdriver.py`py/selenium/webdriver/remote/webdriver.py
get_downloadable_filesfromdicttoList[str].