Skip to content

Conversation

@pranshuchittora
Copy link

@pranshuchittora pranshuchittora commented Jun 25, 2024

User description

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Related to facebook/react-native#45147
[INTERNAL] [SECURITY] - Fixes CVE-2024-37890
https://github.com/websockets/ws/releases/tag/8.17.1

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

dependencies


Description

  • Updated the ws dependency version from >=8.16.0 to >=8.17.1 in package.json to address security vulnerability CVE-2024-37890.
  • Updated the ws dependency version in package-lock.json to ensure consistency with package.json.

Changes walkthrough 📝

Relevant files
Dependencies
package.json
Bump `ws` dependency version to address security vulnerability

javascript/node/selenium-webdriver/package.json

  • Updated the ws dependency version from >=8.16.0 to >=8.17.1.
+1/-1     
package-lock.json
Update `ws` version in lock file to match package.json     

package-lock.json

  • Updated the ws dependency version from >=8.16.0 to >=8.17.1.
+1/-1     

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

@CLAassistant
Copy link

CLAassistant commented Jun 25, 2024

CLA assistant check
All committers have signed the CLA.

@qodo-merge-pro qodo-merge-pro bot added B-dependencies Pull requests that update a dependency file Review effort [1-5]: 1 labels Jun 25, 2024
@qodo-merge-pro
Copy link
Contributor

PR Reviewer Guide 🔍

⏱️ Estimated effort to review [1-5] 1
🧪 Relevant tests No
🔒 Security concerns No
⚡ Key issues to review None

@qodo-merge-pro
Copy link
Contributor

PR Code Suggestions ✨

No code suggestions found for PR.

@VietND96
Copy link
Member

Thank you for your contribution. On trunk it is "ws": "^8.18.0" for now. So, I am closing this PR

@VietND96 VietND96 closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B-dependencies Pull requests that update a dependency file Review effort [1-5]: 1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants