-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[🚀 Feature] [py]: Better compatibility with Appium-python #14587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
|
@p0deje @KazuCocoa what do you think of the changes, would love to get your feedback on this! |
|
@navin772 The changes look good to me, I only wonder if we need to make |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of comments.
I tried to integrate roughly a bit as https://github.com/appium/python-client/compare/selenium?expand=1
Thank you!
|
@KazuCocoa Thanks for the review, I have updated the PR with the requested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I left two comments.
I have also updated appium/python-client#1045 with this PR (and init_args_for_pool_manager modification in this comment)
Co-authored-by: Kazuaki Matsuo <[email protected]>
|
@KazuCocoa updated the PR with the requested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM
cc @p0deje
py/test/selenium/webdriver/remote/remote_custom_locator_tests.py
Outdated
Show resolved
Hide resolved
py/test/unit/selenium/webdriver/remote/remote_connection_tests.py
Outdated
Show resolved
Hide resolved
py/test/unit/selenium/webdriver/remote/remote_connection_tests.py
Outdated
Show resolved
Hide resolved
|
Lgtm |
|
Thank you, @navin772 ! |
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Fixes #13959
This PR implements extensibility points that would be useful in Appium-python client.
Types of changes
Checklist
PR Type
Enhancement, Tests
Description
RemoteConnectionto support extra headers, custom user-agent, and additional HTTP commands.LocatorConverterfor flexible locator conversion logic.Changes walkthrough 📝
by.py
Add support for custom locator strategiespy/selenium/webdriver/common/by.py
locator_converter.py
Introduce LocatorConverter for custom locator conversionpy/selenium/webdriver/remote/locator_converter.py
LocatorConverterclass.remote_connection.py
Enhance RemoteConnection with custom headers and commandspy/selenium/webdriver/remote/remote_connection.py
webdriver.py
Enhance WebDriver with custom locators and elementspy/selenium/webdriver/remote/webdriver.py
LocatorConverterfor element finding.driver_element_finding_tests.py
Add tests for custom locator strategiespy/test/selenium/webdriver/common/driver_element_finding_tests.py
custom_element_tests.py
Add tests for custom web element classespy/test/selenium/webdriver/remote/custom_element_tests.py
remote_custom_locator_tests.py
Add tests for custom locator conversionpy/test/selenium/webdriver/remote/remote_custom_locator_tests.py
remote_connection_tests.py
Add tests for RemoteConnection enhancementspy/test/unit/selenium/webdriver/remote/remote_connection_tests.py