-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[grid] Fix tests for Grid status endpoint and UI #14605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Viet Nguyen Duc <[email protected]>
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
CI Failure Feedback 🧐(Checks updated until commit 625bb94)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR: where Configuration options
See more information about the |
Signed-off-by: Viet Nguyen Duc <[email protected]>
Signed-off-by: Viet Nguyen Duc <[email protected]>
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Fix test CI - RBE
Types of changes
Checklist
PR Type
Bug fix, Tests
Description
NodeStatusforsessionTimeoutandheartbeatPeriodusingcompareTo.GridStatusHandlerto map node status with detailed attributes includingheartbeatPeriodandsessionTimeoutin milliseconds.LocalDistributorTestto includeheartbeatPeriodin node setup and assertions.OverallGridTestto ensure proper navigation in test cases.Changes walkthrough 📝
NodeStatus.java
Fix NodeStatus comparison logic for time durationsjava/src/org/openqa/selenium/grid/data/NodeStatus.java
sessionTimeoutandheartbeatPeriodusingcompareTo.OverallGridTest.java
Fix UI path in OverallGridTest for session and node checksjava/test/org/openqa/selenium/grid/gridui/OverallGridTest.java
GridStatusHandler.java
Enhance GridStatusHandler with detailed node attributesjava/src/org/openqa/selenium/grid/router/GridStatusHandler.java
heartbeatPeriodandsessionTimeoutin milliseconds.LocalDistributorTest.java
Update LocalDistributorTest to include heartbeat periodjava/test/org/openqa/selenium/grid/distributor/local/LocalDistributorTest.java
heartbeatPeriodto node setup and test assertions.