From 321458803aeef305fa13242dd6be75c3a45bf6de Mon Sep 17 00:00:00 2001 From: Alex Date: Wed, 27 Nov 2024 00:53:18 +0700 Subject: [PATCH 1/2] Reports null checks were replaced with a call to a static method from Objects --- java/src/org/openqa/selenium/internal/Require.java | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/java/src/org/openqa/selenium/internal/Require.java b/java/src/org/openqa/selenium/internal/Require.java index 476966a597bb4..f099b1f8c4d4b 100644 --- a/java/src/org/openqa/selenium/internal/Require.java +++ b/java/src/org/openqa/selenium/internal/Require.java @@ -129,11 +129,7 @@ public static int positive(String argName, Integer number, String message) { throw new IllegalArgumentException(String.format(MUST_BE_SET, argName)); } if (number <= 0) { - if (message == null) { - throw new IllegalArgumentException(String.format(MUST_BE_POSITIVE, argName)); - } else { - throw new IllegalArgumentException(message); - } + throw new IllegalArgumentException(Objects.requireNonNullElseGet(message, () -> String.format(MUST_BE_POSITIVE, argName))); } return number; } @@ -143,11 +139,7 @@ public static double positive(String argName, Double number, String message) { throw new IllegalArgumentException(String.format(MUST_BE_SET, argName)); } if (number <= 0) { - if (message == null) { - throw new IllegalArgumentException(String.format(MUST_BE_POSITIVE, argName)); - } else { - throw new IllegalArgumentException(message); - } + throw new IllegalArgumentException(Objects.requireNonNullElseGet(message, () -> String.format(MUST_BE_POSITIVE, argName))); } return number; } From 1fefaba4724a3e1dfa987465834916f0e068635f Mon Sep 17 00:00:00 2001 From: Alex Date: Wed, 27 Nov 2024 01:04:13 +0700 Subject: [PATCH 2/2] applied formatting --- java/src/org/openqa/selenium/internal/Require.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/java/src/org/openqa/selenium/internal/Require.java b/java/src/org/openqa/selenium/internal/Require.java index f099b1f8c4d4b..4ec171e5a305e 100644 --- a/java/src/org/openqa/selenium/internal/Require.java +++ b/java/src/org/openqa/selenium/internal/Require.java @@ -129,7 +129,8 @@ public static int positive(String argName, Integer number, String message) { throw new IllegalArgumentException(String.format(MUST_BE_SET, argName)); } if (number <= 0) { - throw new IllegalArgumentException(Objects.requireNonNullElseGet(message, () -> String.format(MUST_BE_POSITIVE, argName))); + throw new IllegalArgumentException( + Objects.requireNonNullElseGet(message, () -> String.format(MUST_BE_POSITIVE, argName))); } return number; } @@ -139,7 +140,8 @@ public static double positive(String argName, Double number, String message) { throw new IllegalArgumentException(String.format(MUST_BE_SET, argName)); } if (number <= 0) { - throw new IllegalArgumentException(Objects.requireNonNullElseGet(message, () -> String.format(MUST_BE_POSITIVE, argName))); + throw new IllegalArgumentException( + Objects.requireNonNullElseGet(message, () -> String.format(MUST_BE_POSITIVE, argName))); } return number; }