diff --git a/java/src/org/openqa/selenium/chromium/ChromiumDriver.java b/java/src/org/openqa/selenium/chromium/ChromiumDriver.java index f5518714d436f..b5f6dacb3a7bb 100644 --- a/java/src/org/openqa/selenium/chromium/ChromiumDriver.java +++ b/java/src/org/openqa/selenium/chromium/ChromiumDriver.java @@ -147,7 +147,7 @@ protected ChromiumDriver( try { try { - cdpUri = client.flatMap(httpClient -> CdpEndpointFinder.getCdpEndPoint(httpClient)); + cdpUri = client.flatMap(CdpEndpointFinder::getCdpEndPoint); } catch (Exception e) { try { client.ifPresent(HttpClient::close); diff --git a/java/src/org/openqa/selenium/devtools/SeleniumCdpConnection.java b/java/src/org/openqa/selenium/devtools/SeleniumCdpConnection.java index 33a8245ab14dc..12e26cdce1061 100644 --- a/java/src/org/openqa/selenium/devtools/SeleniumCdpConnection.java +++ b/java/src/org/openqa/selenium/devtools/SeleniumCdpConnection.java @@ -77,7 +77,7 @@ public static Optional create( client = reportedUri.map(uri -> CdpEndpointFinder.getHttpClient(clientFactory, uri)); try { - cdpUri = client.flatMap(httpClient -> CdpEndpointFinder.getCdpEndPoint(httpClient)); + cdpUri = client.flatMap(CdpEndpointFinder::getCdpEndPoint); } catch (Exception e) { try { client.ifPresent(HttpClient::close); @@ -87,7 +87,7 @@ public static Optional create( throw e; } - if (!cdpUri.isPresent()) { + if (cdpUri.isEmpty()) { try { client.ifPresent(HttpClient::close); } catch (Exception e) { diff --git a/java/src/org/openqa/selenium/firefox/FirefoxDriver.java b/java/src/org/openqa/selenium/firefox/FirefoxDriver.java index a6beac5461e85..01ec605d2fa08 100644 --- a/java/src/org/openqa/selenium/firefox/FirefoxDriver.java +++ b/java/src/org/openqa/selenium/firefox/FirefoxDriver.java @@ -176,7 +176,7 @@ private FirefoxDriver( Optional cdpUri; try { - cdpUri = client.flatMap(httpClient -> CdpEndpointFinder.getCdpEndPoint(httpClient)); + cdpUri = client.flatMap(CdpEndpointFinder::getCdpEndPoint); } catch (Exception e) { try { client.ifPresent(HttpClient::close); diff --git a/java/src/org/openqa/selenium/remote/RemoteWebDriver.java b/java/src/org/openqa/selenium/remote/RemoteWebDriver.java index 737be829226d7..e0443aea24d89 100644 --- a/java/src/org/openqa/selenium/remote/RemoteWebDriver.java +++ b/java/src/org/openqa/selenium/remote/RemoteWebDriver.java @@ -1247,7 +1247,7 @@ public void addCredential(Credential credential) { Stream.concat( credential.toMap().entrySet().stream(), Stream.of(Map.entry("authenticatorId", id))) - .collect(Collectors.toUnmodifiableMap((e) -> e.getKey(), (e) -> e.getValue()))); + .collect(Collectors.toUnmodifiableMap(Map.Entry::getKey, Map.Entry::getValue))); } @Override diff --git a/java/test/org/openqa/selenium/NoSuchShadowRootTest.java b/java/test/org/openqa/selenium/NoSuchShadowRootTest.java index f945aa6d4561e..78e776366d512 100644 --- a/java/test/org/openqa/selenium/NoSuchShadowRootTest.java +++ b/java/test/org/openqa/selenium/NoSuchShadowRootTest.java @@ -34,6 +34,6 @@ public void getNoSuchShadowRoot() { driver.get(pages.shadowRootPage); WebElement nonExistentShadowRootElement = driver.findElement(By.id("noShadowRoot")); assertThatExceptionOfType(NoSuchShadowRootException.class) - .isThrownBy(() -> nonExistentShadowRootElement.getShadowRoot()); + .isThrownBy(nonExistentShadowRootElement::getShadowRoot); } } diff --git a/java/test/org/openqa/selenium/grid/node/relay/RelayOptionsTest.java b/java/test/org/openqa/selenium/grid/node/relay/RelayOptionsTest.java index 8b02b1e595f7c..e376c13e41fc4 100644 --- a/java/test/org/openqa/selenium/grid/node/relay/RelayOptionsTest.java +++ b/java/test/org/openqa/selenium/grid/node/relay/RelayOptionsTest.java @@ -137,10 +137,7 @@ void protocolVersionThrowsConfigException() { Config config = new TomlConfig(new StringReader(String.join("\n", rawConfig))); RelayOptions relayOptions = new RelayOptions(config); assertThatExceptionOfType(ConfigException.class) - .isThrownBy( - () -> { - relayOptions.getServiceProtocolVersion(); - }) + .isThrownBy(relayOptions::getServiceProtocolVersion) .withMessageContaining("Unsupported protocol version provided: HTTP/0.9"); } diff --git a/java/test/org/openqa/selenium/grid/server/BaseServerOptionsTest.java b/java/test/org/openqa/selenium/grid/server/BaseServerOptionsTest.java index 7aea4479e9300..c92225edfe7a1 100644 --- a/java/test/org/openqa/selenium/grid/server/BaseServerOptionsTest.java +++ b/java/test/org/openqa/selenium/grid/server/BaseServerOptionsTest.java @@ -52,12 +52,7 @@ void externalUriFailsForNonUriStrings() { BaseServerOptions options = new BaseServerOptions(new MapConfig(Map.of("server", Map.of("external-url", "not a URL")))); - Exception exception = - assertThrows( - RuntimeException.class, - () -> { - options.getExternalUri(); - }); + Exception exception = assertThrows(RuntimeException.class, options::getExternalUri); assertThat(exception.getMessage()) .as("External URI must be parseable as URI.")