Skip to content

[js] Update dependency react-modal to v3.16.3 #14951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 28, 2024
Merged

[js] Update dependency react-modal to v3.16.3 #14951

merged 2 commits into from
Dec 28, 2024

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Dec 27, 2024 •
edited
Loading

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
react-modal 3.16.1 -> 3.16.3 age adoption passing confidence

Release Notes

reactjs/react-modal (react-modal)

v3.16.3

Compare Source

  • a5c0cf4 removing restriction on node engines.

v3.16.2

Compare Source

  • b91c724 updade react and react-dom peer dependencies.
  • a275399 simplify PR template.
  • 588f26b contributing requirements now just need a corresponding issue... on GitHub board
  • 449398d remove discussion note from readme.
  • e4841d6 chore: update shouldCloseOnOverlayClick doc
  • 6724a04 Fix tests
  • 7c1d947 Fix badge
  • 96a81be Comment the ellipsis in code blocks in docs/index.md
  • aff8b91 [added] add nodejs version restriction to package.json
  • 321966e [changed] change Miscellaneous related nodejs version text
  • 8dc2347 [added] add Miscellaneous section to the contributions.md file
  • f9bc6a0 [fixed] strict matching for tabbable nodes
  • e7c4a63 downgrade node version on github action.
  • 1a8f562 running tests on github actions

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added C-nodejs JavaScript Bindings B-dependencies Pull requests that update a dependency file labels Dec 27, 2024
@qodo-merge-pro
Copy link
Contributor

qodo-merge-pro bot commented Dec 27, 2024 •
edited
Loading

CI Failure Feedback 🧐

(Checks updated until commit 6b4fd17)

Action: Check format / Check format script run

Failed stage: Run Bazel [❌]

Failure summary:

The action failed because the pnpm-lock.yaml file was updated during the build process, which
requires a rebuild:

  • The error occurred during the fetch of repository 'aspect_rules_js~~npm~npm'
  • The build system detected that pnpm-lock.yaml was modified
  • As per the error message, the build needs to be run again after the lock file update
  • This is a known issue referenced in [Bug]: update_pnpm_lock fails under Bzlmod, retry fixes it aspect-build/rules_js#1445

    • Relevant error logs: 
    1:  ##[group]Operating System
2:  Ubuntu
...

961:  Package 'php-symfony-debug-bundle' is not installed, so not removed
962:  Package 'php-symfony-dependency-injection' is not installed, so not removed
963:  Package 'php-symfony-deprecation-contracts' is not installed, so not removed
964:  Package 'php-symfony-discord-notifier' is not installed, so not removed
965:  Package 'php-symfony-doctrine-bridge' is not installed, so not removed
966:  Package 'php-symfony-doctrine-messenger' is not installed, so not removed
967:  Package 'php-symfony-dom-crawler' is not installed, so not removed
968:  Package 'php-symfony-dotenv' is not installed, so not removed
969:  Package 'php-symfony-error-handler' is not installed, so not removed
...

1869:  �[32mLoading:�[0m 0 packages loaded
1870:  currently loading: 
1871:  �[32mLoading:�[0m 0 packages loaded
1872:  currently loading: 
1873:  �[32mINFO: �[0mRepository aspect_rules_js~~npm~npm instantiated at:
1874:  <builtin>: in <toplevel>
1875:  Repository rule npm_translate_lock_rule defined at:
1876:  /home/runner/.bazel/external/aspect_rules_js~/npm/private/npm_translate_lock.bzl:146:42: in <toplevel>
1877:  �[31m�[1mERROR: �[0mAn error occurred during the fetch of repository 'aspect_rules_js~~npm~npm':
1878:  Traceback (most recent call last):
1879:  File "/home/runner/.bazel/external/aspect_rules_js~/npm/private/npm_translate_lock.bzl", line 112, column 21, in _npm_translate_lock_impl
1880:  fail(msg)
1881:  Error in fail: 
1882:  INFO: pnpm-lock.yaml file updated. Please run your build again.
1883:  See https://github.com/aspect-build/rules_js/issues/1445
1884:  �[32mLoading:�[0m 0 packages loaded
1885:  currently loading: 
1886:  �[35mWARNING: �[0mTarget pattern parsing failed.
1887:  �[31m�[1mERROR: �[0mSkipping '//:buildifier': no such package '@@aspect_rules_js~~npm~npm//': 
1888:  INFO: pnpm-lock.yaml file updated. Please run your build again.
1889:  See https://github.com/aspect-build/rules_js/issues/1445
1890:  �[31m�[1mERROR: �[0mno such package '@@aspect_rules_js~~npm~npm//': 
1891:  INFO: pnpm-lock.yaml file updated. Please run your build again.
1892:  See https://github.com/aspect-build/rules_js/issues/1445
1893:  �[32mINFO: �[0mElapsed time: 23.057s
1894:  �[32mINFO: �[0m0 processes.
1895:  �[31m�[1mERROR: �[0mBuild did NOT complete successfully
1896:  �[31m�[1mERROR: �[0mBuild failed. Not running target
1897:  �[0m
1898:  ##[error]Process completed with exit code 1.
    ✨ CI feedback usage guide:

    The CI feedback tool (/checks) automatically triggers when a PR has a failed check.
    The tool analyzes the failed checks and provides several feedbacks:

    • Failed stage
    • Failed test name
    • Failure summary
    • Relevant error logs

    In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:

    /checks "https://github.com/{repo_name}/actions/runs/{run_number}/job/{job_number}"

    where {repo_name} is the name of the repository, {run_number} is the run number of the failed check, and {job_number} is the job number of the failed check.

    Configuration options

    • enable_auto_checks_feedback - if set to true, the tool will automatically provide feedback when a check is failed. Default is true.
    • excluded_checks_list - a list of checks to exclude from the feedback, for example: ["check1", "check2"]. Default is an empty list.
    • enable_help_text - if set to true, the tool will provide a help message with the feedback. Default is true.
    • persistent_comment - if set to true, the tool will overwrite a previous checks comment with the new feedback. Default is true.
    • final_update_message - if persistent_comment is true and updating a previous checks message, the tool will also create a new message: "Persistent checks updated to latest commit". Default is true.

    See more information about the checks tool in the docs.

    @renovate renovate bot force-pushed the renovate/react-modal-3.x branch from 6b4fd17 to 6ce7e2e Compare December 28, 2024 10:55
    @diemol diemol merged commit b19a5d0 into trunk Dec 28, 2024
    1 check passed
    @diemol diemol deleted the renovate/react-modal-3.x branch December 28, 2024 11:08
    sandeepsuryaprasad pushed a commit to sandeepsuryaprasad/selenium that referenced this pull request Mar 23, 2025
    @renovate @selenium-ci @sandeepsuryaprasad
    [js] Update dependency react-modal to v3.16.3 (SeleniumHQ#14951)
    87bf15e 
    * [js] Update dependency react-modal to v3.16.3

* Repin dependencies

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Selenium CI Bot <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    No reviews

    Assignees

    No one assigned

    Labels

    B-dependencies Pull requests that update a dependency file C-nodejs JavaScript Bindings

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    3 participants

    @diemol @selenium-ci