Skip to content

Allow sending DevTools command with custom timeout. #15059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 15, 2025
Merged

Allow sending DevTools command with custom timeout. #15059

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2f18649
Allow sending DevTools command with custom timeout.
dennisoelkers Jan 10, 2025
81e68a3
Merge branch 'trunk' into feat/configurable-timeout-for-devtools-comm…
dennisoelkers Jan 10, 2025
b96a332
Merge branch 'trunk' into feat/configurable-timeout-for-devtools-comm…
pujagani Jan 13, 2025
aafdb81
Renaming method to `send`.
dennisoelkers Jan 15, 2025
700e529
Merge branch 'trunk' into feat/configurable-timeout-for-devtools-comm…
diemol Jan 15, 2025
a56f32d
Using correct method in default `send`.
dennisoelkers Jan 15, 2025
91a01dc
Fixing formatting.
dennisoelkers Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions java/src/org/openqa/selenium/devtools/DevTools.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,12 @@ public void disconnectSession() {
}

public <X> X send(Command<X> command) {
Require.nonNull("Command to send", command);
return connection.sendAndWait(cdpSession, command, timeout);
return sendWithTimeout(command, this.timeout);
Copy link
Member

@navin772 navin772 Jan 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename this also:

Suggested change
return sendWithTimeout(command, this.timeout);
return send(command, this.timeout);

Copy link
Contributor Author

@dennisoelkers dennisoelkers Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My fault, sorry. Updated the PR. 👍

}

public <X> X sendWithTimeout(Command<X> command, Duration timeout) {
Require.nonNull("Command to send", command);
return connection.sendAndWait(cdpSession, command, timeout);
}

/**
Expand Down
Loading