Skip to content

[py] Fix installing most of the data from source distributions #15145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 27, 2025
Merged

[py] Fix installing most of the data from source distributions #15145

merged 2 commits into from
Jan 27, 2025

Conversation

@VietND96
Copy link
Member

@VietND96 VietND96 commented Jan 24, 2025 •
edited
Loading

User description

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Continue #15128

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Enhancement, Dependencies

Description

  • Added support for Python 3.13 in Bazel configuration.

  • Introduced pyo3 dependency in Rust's Cargo.toml for Python extension modules.

Changes walkthrough 📝

Relevant files
Enhancement
MODULE.bazel
Add Python 3.13 support in Bazel configuration                     

MODULE.bazel

  • Added Python 3.13 to the list of supported Python versions.
  • Updated Bazel configuration to include Python 3.13 toolchain.
    		• +2/-0     
    Dependencies
    Cargo.toml
    Introduce pyo3 dependency for Python extension modules     

    rust/Cargo.toml

  • Added pyo3 dependency with extension-module feature.
  • Updated dependencies to support Python extension modules.
    		• +1/-0     
    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
    •

    @qodo-merge-pro
    Copy link
    Contributor

    qodo-merge-pro bot commented Jan 24, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    @qodo-merge-pro
    Copy link
    Contributor

    qodo-merge-pro bot commented Jan 24, 2025

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    General
    Add version constraint flexibility

    Specify a minimum version constraint for pyo3 to ensure compatibility with older
    Python versions. Use '>=' instead of a fixed version.

    rust/Cargo.toml [41]

    -pyo3 = { version = "0.23.4", features = ["extension-module"] }
+pyo3 = { version = ">=0.23.4", features = ["extension-module"] }
    • Apply this suggestion
    Suggestion importance[1-10]: 5

    Why: Using '>=' instead of a fixed version provides more flexibility for dependency updates while maintaining minimum compatibility requirements. However, this is a minor improvement as fixed versions can also be beneficial for reproducibility.

    		5

    @qodo-merge-pro
    Copy link
    Contributor

    qodo-merge-pro bot commented Jan 24, 2025 •
    edited
    Loading

    CI Feedback 🧐

    (Feedback updated until commit 2c94fad)

    A test triggered by this PR failed. Here is an AI-generated analysis of the failure:

    Action: Python / Browser Tests (chrome, ubuntu) / Integration Tests (chrome, ubuntu)

    Failed stage: Setup Fluxbox and Xvfb [❌]

    Failure summary:

    The action failed during package installation because it couldn't fetch a required package:

  • Failed to fetch libopenjp2-7 package from the Ubuntu repository
  • Got a 404 (Not Found) error when trying to download from mirror URL
  • The error suggests running apt-get update or using --fix-missing flag to resolve the issue

    • Relevant error logs: 
    1:  ##[group]Operating System
2:  Ubuntu
...

941:  Package 'php-symfony-asset' is not installed, so not removed
942:  Package 'php-symfony-asset-mapper' is not installed, so not removed
943:  Package 'php-symfony-browser-kit' is not installed, so not removed
944:  Package 'php-symfony-clock' is not installed, so not removed
945:  Package 'php-symfony-debug-bundle' is not installed, so not removed
946:  Package 'php-symfony-doctrine-bridge' is not installed, so not removed
947:  Package 'php-symfony-dom-crawler' is not installed, so not removed
948:  Package 'php-symfony-dotenv' is not installed, so not removed
949:  Package 'php-symfony-error-handler' is not installed, so not removed
...

1135:  Package 'php-uopz-all-dev' is not installed, so not removed
1136:  Package 'php8.3-uploadprogress' is not installed, so not removed
1137:  Package 'php-uploadprogress-all-dev' is not installed, so not removed
1138:  Package 'php8.3-uuid' is not installed, so not removed
1139:  Package 'php-uuid-all-dev' is not installed, so not removed
1140:  Package 'php-validate' is not installed, so not removed
1141:  Package 'php-vlucas-phpdotenv' is not installed, so not removed
1142:  Package 'php-voku-portable-ascii' is not installed, so not removed
1143:  Package 'php-wmerrors' is not installed, so not removed
...

1868:  Get:33 http://azure.archive.ubuntu.com/ubuntu noble/main amd64 fonts-noto-mono all 20201225-2 [435 kB]
1869:  Get:34 http://azure.archive.ubuntu.com/ubuntu noble/universe amd64 fonts-terminus-otb all 4.48-3.1 [308 kB]
1870:  Get:35 http://azure.archive.ubuntu.com/ubuntu noble-updates/main amd64 libheif-plugin-aomenc amd64 1.17.6-1ubuntu4.1 [14.7 kB]
1871:  Get:36 http://azure.archive.ubuntu.com/ubuntu noble/universe amd64 libjpeg9 amd64 1:9e-1build1 [126 kB]
1872:  Get:37 http://azure.archive.ubuntu.com/ubuntu noble/universe amd64 libjpeg-progs amd64 1:9e-1build1 [81.0 kB]
1873:  Get:38 http://azure.archive.ubuntu.com/ubuntu noble/main amd64 libpaper-utils amd64 1.1.29build1 [8650 B]
1874:  Get:39 http://azure.archive.ubuntu.com/ubuntu noble/main amd64 librsvg2-common amd64 2.58.0+dfsg-1build1 [11.8 kB]
1875:  Get:40 http://azure.archive.ubuntu.com/ubuntu noble/universe amd64 xfonts-terminus all 4.48-3.1 [1524 kB]
1876:  E: Failed to fetch mirror+file:/etc/apt/apt-mirrors.txt/pool/main/o/openjpeg2/libopenjp2-7_2.5.0-2ubuntu0.2_amd64.deb  404  Not Found [IP: 52.147.219.192 80]
1877:  Fetched 32.7 MB in 2s (17.3 MB/s)
1878:  E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
1879:  ##[error]Process completed with exit code 100.

    @VietND96 VietND96 force-pushed the pyo3 branch 4 times, most recently from 477760b to c4d453b Compare January 24, 2025 12:35
    @VietND96 VietND96 changed the title [py] Fix installing selenium-manager from source distributions [py] Fix installing most of the data from source distributions Jan 24, 2025
    @VietND96 VietND96 merged commit 9cb1db9 into trunk Jan 27, 2025
    16 of 17 checks passed
    @VietND96 VietND96 deleted the pyo3 branch January 27, 2025 03:41
    sandeepsuryaprasad pushed a commit to sandeepsuryaprasad/selenium that referenced this pull request Mar 23, 2025
    @VietND96 @sandeepsuryaprasad
    [py] Fix installing most of the data from source distributions (Selen…
    44b9d12 
    …iumHQ#15145)
    gryznar pushed a commit to gryznar/selenium that referenced this pull request May 17, 2025
    @VietND96 @gryznar
    [py] Fix installing most of the data from source distributions (Selen…
    8c5616d 
    …iumHQ#15145)
    @dependabot dependabot bot mentioned this pull request Sep 18, 2025
    Merged
    @dependabot dependabot bot mentioned this pull request Oct 1, 2025
    Closed
    @dependabot dependabot bot mentioned this pull request Oct 24, 2025
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    No reviews

    Assignees

    No one assigned

    Labels

    Review effort [1-5]: 1

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    2 participants

    @VietND96