Skip to content

[py] service: only shutdown if process not terminated #15183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 23, 2025
Merged

[py] service: only shutdown if process not terminated #15183

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1eb1fbd
service: only shutdown if process not terminated
PSandro Jan 29, 2025
831a859
Merge branch 'trunk' into fix-service-stop-process
VietND96 Feb 9, 2025
9d83081
Merge branch 'trunk' into fix-service-stop-process
cgoldberg Mar 21, 2025
7ed046c
Merge branch 'trunk' into fix-service-stop-process
shbenzer Mar 21, 2025
eb19349
service: move process termination to finally block
PSandro Mar 22, 2025
2ef9d9a
Merge branch 'trunk' into fix-service-stop-process
PSandro Mar 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion py/selenium/webdriver/common/service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ def stop(self) -> None:
elif isinstance(self.log_output, int):
os.close(self.log_output)

if self.process is not None:
if self.process is not None and self.process.poll() is None:
try:
self.send_remote_shutdown_command()
except TypeError:
Expand Down