Skip to content

Conversation

@RenderMichael
Copy link
Contributor

@RenderMichael RenderMichael commented Mar 11, 2025

Description

  • Add remaining PrimitiveProtocolValue
    • RemoteValue.BigInt
    • LocalValue.BigInt
    • LocalValue.Boolean
  • Add a number of helpers to convert between .NET types and BiDi types

Motivation and Context

We were missing some PrimitiveProtocolValues: BigInt and Boolean on the local side, and BigInt on the remote side.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes. // Will update after similar PR gets merged
  • All new and existing tests passed.

@nvborisenko
Copy link
Member

So many conceptual stuff here to be analyzed.

@RenderMichael
Copy link
Contributor Author

Still WIP 😄

@nvborisenko
Copy link
Member

As in related PR #15395 I propose to gather json payloads to see how it is implemented by vendors to choose the best way how to handle it.

@RenderMichael RenderMichael deleted the dotnet-localvalue branch March 21, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants