Skip to content

[py] Only skip WebKit tests on Windows #15470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 5, 2025
Merged

[py] Only skip WebKit tests on Windows #15470

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9d78c50
[py] Only skip WebKit tests on Windows
cgoldberg Mar 21, 2025
8043e00
[py] fix grammar error
cgoldberg Mar 21, 2025
b4e68f9
Merge branch 'SeleniumHQ:trunk' into py-tests-webkit-skip
cgoldberg Mar 29, 2025
bec5bbe
Merge branch 'trunk' into py-tests-webkit-skip
cgoldberg Apr 3, 2025
4676221
Merge branch 'SeleniumHQ:trunk' into py-tests-webkit-skip
cgoldberg Apr 5, 2025
b51db93
Merge branch 'SeleniumHQ:trunk' into py-tests-webkit-skip
cgoldberg Apr 5, 2025
9cfbaf0
Merge branch 'trunk' into py-tests-webkit-skip
cgoldberg Apr 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions py/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,8 @@ def driver(request):
pytest.skip("Safari tests can only run on an Apple OS")
if (driver_class == "Ie") and _platform != "Windows":
pytest.skip("IE and EdgeHTML Tests can only run on Windows")
if "WebKit" in driver_class and _platform != "Linux":
pytest.skip("Webkit tests can only run on Linux")
if "WebKit" in driver_class and _platform == "Windows":
pytest.skip("WebKit tests cannot be run on Windows")

# conditionally mark tests as expected to fail based on driver
marker = request.node.get_closest_marker(f"xfail_{driver_class.lower()}")
Expand Down
Loading