From 8c317d89e6b88bb5a59c9e38a0485f3c15fa804e Mon Sep 17 00:00:00 2001 From: titusfortner Date: Sat, 22 Mar 2025 11:12:31 -0700 Subject: [PATCH 1/2] [build] allow tests tagged exclusive-if-local to run on rbe --- .bazelrc.remote | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.bazelrc.remote b/.bazelrc.remote index 40f864f95cda2..7b50bef8b48f1 100644 --- a/.bazelrc.remote +++ b/.bazelrc.remote @@ -31,7 +31,7 @@ build:remote --disk_cache= build:remote --incompatible_enable_cc_toolchain_resolution build:remote --action_env=BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1 test:remote --test_env=DISPLAY=:99.0 -test:remote --test_tag_filters=-exclusive-if-local,-skip-rbe,-remote +test:remote --test_tag_filters=-skip-rbe,-remote # Env vars we can hard code build:remote --action_env=HOME=/home/dev From f05e0eb6fca9fab645438045ea70276691d1825a Mon Sep 17 00:00:00 2001 From: aguspe Date: Wed, 26 Mar 2025 19:41:33 +0100 Subject: [PATCH 2/2] Fix bug where symbol is not accepting on delete cookie --- rb/lib/selenium/webdriver/remote/bridge.rb | 2 +- rb/spec/integration/selenium/webdriver/manager_spec.rb | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/rb/lib/selenium/webdriver/remote/bridge.rb b/rb/lib/selenium/webdriver/remote/bridge.rb index 1cd1c63deddf8..d4318a25b0088 100644 --- a/rb/lib/selenium/webdriver/remote/bridge.rb +++ b/rb/lib/selenium/webdriver/remote/bridge.rb @@ -323,7 +323,7 @@ def add_cookie(cookie) end def delete_cookie(name) - raise ArgumentError, 'Cookie name cannot be null or empty' if name.nil? || name.strip.empty? + raise ArgumentError, 'Cookie name cannot be null or empty' if name.nil? || name.to_s.strip.empty? execute :delete_cookie, name: name end diff --git a/rb/spec/integration/selenium/webdriver/manager_spec.rb b/rb/spec/integration/selenium/webdriver/manager_spec.rb index 021033930bef2..1245c76fa20ce 100644 --- a/rb/spec/integration/selenium/webdriver/manager_spec.rb +++ b/rb/spec/integration/selenium/webdriver/manager_spec.rb @@ -268,6 +268,12 @@ module WebDriver expect { driver.manage.delete_cookie(nil) } .to raise_error(ArgumentError, /Cookie name cannot be null or empty/) end + + it 'allows deleting a cookies using a symbol' do + driver.manage.add_cookie name: :foo, value: 'bar' + driver.manage.delete_cookie(:foo) + expect(driver.manage.all_cookies).to be_empty + end end end # Options end # WebDriver