[py] Fix test args for --headless and --bidi

[cgoldberg]

User description

💥 What does this PR do?

This PR fixes some of the argument handling for invoking tests in the internal Python test suite.

Previously, to enable headless mode, you would pass --headless=true when invoking PyTest. This worked fine, however, passing any value would enable headless mode (including --headless=false, --headless=False, --headless=0, --headless=no, --headless=what_the_hell_is_this, etc). This was rather confusing. Now to enable headless mode, you pass --headless. To run without headless mode, you just don't supply the argument. If you try to pass a value like --headless=value, it will raise an error.

Similarly, the --bidi arg was handled incorrectly. Bazel was invoking non-BiDi tests by passing --bidi=false, which had the effect of enabling BiDi mode. Now this arg works similar to --headless. You simply pass --bidi to enable BiDi mode in tests, or leave the arg off to run in non-BiDi mode.

I updated py/BUILD.bazel to invoke tests in BiDi and Headless modes correctly.

I also cleaned up some of the help strings.

🔄 Types of changes

• Cleanup (formatting, renaming)
• Bug fix (backwards compatible)

---

PR Type

Bug fix, Enhancement

---

Description

• Fixed argument handling for --headless and --bidi in Python tests.

• Updated Bazel build configurations to correctly handle test arguments.

• Improved help text for test arguments in pytest_addoption.

• Simplified logic for headless and BiDi mode detection.

---

Changes walkthrough 📝

	Relevant files
Bug fix	conftest.py Refined test argument handling and help text                          py/conftest.py Changed --headless and --bidi to store_true for better handling. Updated help text for multiple test arguments for clarity. Simplified logic for headless and bidi mode detection. +11/-12
Configuration changes	BUILD.bazel Fixed Bazel test configurations for arguments                        py/BUILD.bazel Removed incorrect --bidi=false argument in test configurations. Updated --bidi and --headless arguments for proper usage. Adjusted Bazel test suite configurations for headless and BiDi modes. +2/-3

---

Need help?

Type /help how to ... in the comments thread for any questions about Qodo Merge usage.

Check out the documentation for more information.

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Backward Compatibility The change from action="store" to action="store_true" for the headless and bidi options might break existing test scripts that use --headless=true syntax. Consider adding a deprecation warning if old syntax is detected. action="store_true", dest="headless",

[qodo-merge-pro]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Missing explicit BiDi configuration The PR removed the --bidi=false flag but didn't add an equivalent replacement. Since the flag was changed to store_true in conftest.py, tests that previously had BiDi explicitly disabled will now use the default value, which could lead to unexpected behavior. py/BUILD.bazel [406-408] args = [ "--instafail", + # BiDi is explicitly disabled for these tests ] + BROWSERS[browser]["args"], Apply this suggestion Suggestion importance[1-10]: 7 __ Why: The suggestion correctly identifies that removing "--bidi=false" without replacement could change test behavior. Since the flag was changed to store_true in conftest.py, tests that previously had BiDi explicitly disabled will now use the default value (False), but making this explicit would improve clarity and prevent future issues.	Medium
Update

[cgoldberg]

The issue that AI reviewer brought up (If anybody was previously invoking tests with --bidi=false, this will now lead to unexpected behavior) is not a concern because --bidi=false was completely broken previously.