From 91e4c15b7e155fe259fa185299a562a367a7d095 Mon Sep 17 00:00:00 2001
From: Corey Goldberg <1113081+cgoldberg@users.noreply.github.com>
Date: Sun, 6 Apr 2025 20:00:04 -0400
Subject: [PATCH] [py] Fix FedCM tests leaking state

---
 py/test/selenium/webdriver/common/fedcm_tests.py | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/py/test/selenium/webdriver/common/fedcm_tests.py b/py/test/selenium/webdriver/common/fedcm_tests.py
index 868fdd991e27e..a187f1c6c1182 100644
--- a/py/test/selenium/webdriver/common/fedcm_tests.py
+++ b/py/test/selenium/webdriver/common/fedcm_tests.py
@@ -62,16 +62,19 @@ def test_trigger_and_verify_dialog_title(self, driver):
         driver.execute_script("triggerFedCm();")
         dialog = driver.fedcm_dialog()
         assert dialog.title == "Sign in to localhost with localhost"
+        dialog.dismiss()
 
     def test_trigger_and_verify_dialog_subtitle(self, driver):
         driver.execute_script("triggerFedCm();")
         dialog = driver.fedcm_dialog()
         assert dialog.subtitle is None
+        dialog.dismiss()
 
     def test_trigger_and_verify_dialog_type(self, driver):
         driver.execute_script("triggerFedCm();")
         dialog = driver.fedcm_dialog()
         assert dialog.type == "AccountChooser"
+        dialog.dismiss()
 
     def test_trigger_and_verify_account_list(self, driver):
         driver.execute_script("triggerFedCm();")
@@ -79,6 +82,7 @@ def test_trigger_and_verify_account_list(self, driver):
         accounts = dialog.get_accounts()
         assert len(accounts) > 0
         assert accounts[0].name == "John Doe"
+        dialog.dismiss()
 
     def test_select_account(self, driver):
         driver.execute_script("triggerFedCm();")
@@ -86,6 +90,7 @@ def test_select_account(self, driver):
         dialog.select_account(1)
         driver.fedcm_dialog()  # Wait for dialog to become interactable
         # dialog.click_continue()
+        dialog.dismiss()
 
     def test_dialog_cancel(self, driver):
         driver.execute_script("triggerFedCm();")
@@ -136,3 +141,4 @@ def test_verify_dialog_type_after_cooldown_reset(self, driver):
         driver.execute_script("triggerFedCm();")
         dialog = driver.fedcm_dialog()
         assert dialog.type == "AccountChooser"
+        dialog.dismiss()