From 85b27e8389ac5c4dccb364747768d3d93ceaaa92 Mon Sep 17 00:00:00 2001 From: Corey Goldberg <1113081+cgoldberg@users.noreply.github.com> Date: Wed, 9 Apr 2025 20:09:07 -0400 Subject: [PATCH] [py] Fix failing test for Edge logging --- .../webdriver/edge/edge_service_tests.py | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/py/test/selenium/webdriver/edge/edge_service_tests.py b/py/test/selenium/webdriver/edge/edge_service_tests.py index 43416faf76b70..bcf00b4af087a 100644 --- a/py/test/selenium/webdriver/edge/edge_service_tests.py +++ b/py/test/selenium/webdriver/edge/edge_service_tests.py @@ -30,21 +30,30 @@ def test_uses_edgedriver_logging(clean_driver, driver_executable) -> None: log_file = "msedgedriver.log" service_args = ["--append-log"] - service = Service( + service1 = Service( log_output=log_file, service_args=service_args, executable_path=driver_executable, ) + + service2 = Service( + log_output=log_file, + service_args=service_args, + executable_path=driver_executable, + ) + + driver1 = None driver2 = None try: - driver1 = clean_driver(service=service) + driver1 = clean_driver(service=service1) with open(log_file) as fp: lines = len(fp.readlines()) - driver2 = clean_driver(service=service) + driver2 = clean_driver(service=service2) with open(log_file) as fp: assert len(fp.readlines()) >= 2 * lines finally: - driver1.quit() + if driver1: + driver1.quit() if driver2: driver2.quit() os.remove(log_file)