From 31c6b881938200b09c99cc0d24460b798ca07f29 Mon Sep 17 00:00:00 2001 From: Delta456 Date: Wed, 23 Apr 2025 14:52:06 +0530 Subject: [PATCH] [java] enable Edge BiDi tests for network module --- .../selenium/bidi/network/AddInterceptParametersTest.java | 8 -------- java/test/org/openqa/selenium/bidi/network/BUILD.bazel | 1 + .../openqa/selenium/bidi/network/NetworkCommandsTest.java | 1 - .../openqa/selenium/bidi/network/NetworkEventsTest.java | 4 ---- 4 files changed, 1 insertion(+), 13 deletions(-) diff --git a/java/test/org/openqa/selenium/bidi/network/AddInterceptParametersTest.java b/java/test/org/openqa/selenium/bidi/network/AddInterceptParametersTest.java index 28ce439a3a653..27bf43639420f 100644 --- a/java/test/org/openqa/selenium/bidi/network/AddInterceptParametersTest.java +++ b/java/test/org/openqa/selenium/bidi/network/AddInterceptParametersTest.java @@ -18,20 +18,17 @@ package org.openqa.selenium.bidi.network; import static org.assertj.core.api.AssertionsForClassTypes.assertThat; -import static org.openqa.selenium.testing.drivers.Browser.EDGE; import java.util.List; import org.junit.jupiter.api.Test; import org.openqa.selenium.bidi.module.Network; import org.openqa.selenium.testing.JupiterTestBase; import org.openqa.selenium.testing.NeedsFreshDriver; -import org.openqa.selenium.testing.NotYetImplemented; class AddInterceptParametersTest extends JupiterTestBase { @Test @NeedsFreshDriver - @NotYetImplemented(EDGE) void canAddInterceptPhase() { try (Network network = new Network(driver)) { String intercept = @@ -42,7 +39,6 @@ void canAddInterceptPhase() { @Test @NeedsFreshDriver - @NotYetImplemented(EDGE) void canAddInterceptPhases() { try (Network network = new Network(driver)) { String intercept = @@ -55,7 +51,6 @@ void canAddInterceptPhases() { @Test @NeedsFreshDriver - @NotYetImplemented(EDGE) void canAddStringUrlPattern() { try (Network network = new Network(driver)) { String intercept = @@ -68,7 +63,6 @@ void canAddStringUrlPattern() { @Test @NeedsFreshDriver - @NotYetImplemented(EDGE) void canAddStringUrlPatterns() { try (Network network = new Network(driver)) { String intercept = @@ -84,7 +78,6 @@ void canAddStringUrlPatterns() { @Test @NeedsFreshDriver - @NotYetImplemented(EDGE) void canAddUrlPattern() { try (Network network = new Network(driver)) { UrlPattern pattern = @@ -104,7 +97,6 @@ void canAddUrlPattern() { @Test @NeedsFreshDriver - @NotYetImplemented(EDGE) void canAddUrlPatterns() { try (Network network = new Network(driver)) { UrlPattern pattern1 = diff --git a/java/test/org/openqa/selenium/bidi/network/BUILD.bazel b/java/test/org/openqa/selenium/bidi/network/BUILD.bazel index 3068b724013b7..18e47b0ad907d 100644 --- a/java/test/org/openqa/selenium/bidi/network/BUILD.bazel +++ b/java/test/org/openqa/selenium/bidi/network/BUILD.bazel @@ -8,6 +8,7 @@ java_selenium_test_suite( browsers = [ "firefox", "chrome", + "edge", ], tags = [ "selenium-remote", diff --git a/java/test/org/openqa/selenium/bidi/network/NetworkCommandsTest.java b/java/test/org/openqa/selenium/bidi/network/NetworkCommandsTest.java index 15d4fdeffabd4..b6347925cd67e 100644 --- a/java/test/org/openqa/selenium/bidi/network/NetworkCommandsTest.java +++ b/java/test/org/openqa/selenium/bidi/network/NetworkCommandsTest.java @@ -57,7 +57,6 @@ void canAddIntercept() { @Test @NeedsFreshDriver - @NotYetImplemented(EDGE) void canContinueRequest() throws InterruptedException { try (Network network = new Network(driver)) { String intercept = diff --git a/java/test/org/openqa/selenium/bidi/network/NetworkEventsTest.java b/java/test/org/openqa/selenium/bidi/network/NetworkEventsTest.java index f4a0b10f5bd03..c3af6af482b53 100644 --- a/java/test/org/openqa/selenium/bidi/network/NetworkEventsTest.java +++ b/java/test/org/openqa/selenium/bidi/network/NetworkEventsTest.java @@ -39,7 +39,6 @@ class NetworkEventsTest extends JupiterTestBase { @Test @NeedsFreshDriver - @NotYetImplemented(EDGE) void canListenToBeforeRequestSentEvent() throws ExecutionException, InterruptedException, TimeoutException { try (Network network = new Network(driver)) { @@ -60,7 +59,6 @@ void canListenToBeforeRequestSentEvent() @Test @NeedsFreshDriver - @NotYetImplemented(EDGE) void canListenToResponseStartedEvent() throws ExecutionException, InterruptedException, TimeoutException { try (Network network = new Network(driver)) { @@ -83,7 +81,6 @@ void canListenToResponseStartedEvent() @Test @NeedsFreshDriver - @NotYetImplemented(EDGE) void canListenToResponseCompletedEvent() throws ExecutionException, InterruptedException, TimeoutException { try (Network network = new Network(driver)) { @@ -106,7 +103,6 @@ void canListenToResponseCompletedEvent() @Test @NeedsFreshDriver - @NotYetImplemented(EDGE) void canListenToResponseCompletedEventWithCookie() throws ExecutionException, InterruptedException, TimeoutException { try (Network network = new Network(driver)) {