Skip to content

[java][BiDi] enable Edge BiDi tests for network module #15661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 24, 2025
Merged

[java][BiDi] enable Edge BiDi tests for network module #15661

merged 4 commits into from
Apr 24, 2025

Conversation

@Delta456
Copy link
Member

@Delta456 Delta456 commented Apr 23, 2025 •
edited by qodo-merge-pro bot
Loading

User description

🔗 Related Issues

None

💥 What does this PR do?

Enables Edge BiDi tests for network module

🔧 Implementation Notes

This is a follow-up of ac98d8f

💡 Additional Considerations

🔄 Types of changes

  • Bug fix (backwards compatible)

PR Type

Tests

Description

  • Enable Edge BiDi tests for the network module

  • Remove Edge-specific test exclusions for network BiDi tests

  • Update Bazel build to include Edge in network tests

Changes walkthrough 📝

Relevant files
Configuration changes
BUILD.bazel
Add Edge to network module test browsers in Bazel               

java/test/org/openqa/selenium/bidi/network/BUILD.bazel

  • Add "edge" to the list of browsers for network tests
  • Ensures network tests run on Edge in addition to Chrome and Firefox
    		• +1/-0     
    Tests
    AddInterceptParametersTest.java
    Enable Edge for AddInterceptParameters network tests         

    java/test/org/openqa/selenium/bidi/network/AddInterceptParametersTest.java

  • Remove @NotYetImplemented(EDGE) from all test methods
  • Allows all AddInterceptParameters network tests to run on Edge
    		• +0/-8     
    NetworkCommandsTest.java
    Enable Edge for NetworkCommands canContinueRequest test   

    java/test/org/openqa/selenium/bidi/network/NetworkCommandsTest.java

  • Remove @NotYetImplemented(EDGE) from canContinueRequest test
  • Enables this network command test for Edge
    		• +0/-1     
    NetworkEventsTest.java
    Enable Edge for NetworkEvents network tests                           

    java/test/org/openqa/selenium/bidi/network/NetworkEventsTest.java

  • Remove @NotYetImplemented(EDGE) from all network event test methods
  • Enables event listening network tests for Edge
    		• +0/-4     
    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
    •

    @selenium-ci selenium-ci added C-java Java Bindings B-build Includes scripting, bazel and CI integrations B-devtools Includes everything BiDi or Chrome DevTools related labels Apr 23, 2025
    @qodo-merge-pro
    Copy link
    Contributor

    qodo-merge-pro bot commented Apr 23, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    🎫 Ticket compliance analysis ❌

    1234 - Not compliant

    Non-compliant requirements:

    • Fix issue where Selenium 2.48 doesn't trigger JavaScript in link's href on click()
    • Ensure JavaScript in href attributes works properly in Firefox 42.0

    5678 - Not compliant

    Non-compliant requirements:

    • Fix "ConnectFailure (Connection refused)" error when instantiating ChromeDriver
    • Address issue where subsequent ChromeDriver instantiations fail after the first one works

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 PR contains tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    @qodo-merge-pro
    Copy link
    Contributor

    qodo-merge-pro bot commented Apr 23, 2025 •
    edited
    Loading

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @Delta456 Delta456 requested a review from pujagani April 23, 2025 10:12
    shbenzer
    shbenzer approved these changes Apr 24, 2025
    View reviewed changes
    Copy link
    Contributor

    @shbenzer shbenzer left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM

    //java/test/org/openqa/selenium/bidi/network:NetworkCommandsTest-edge    PASSED in 41.6s
//java/test/org/openqa/selenium/bidi/network:NetworkCommandsTest-edge-remote PASSED in 52.8s
//java/test/org/openqa/selenium/bidi/network:NetworkEventsTest-edge      PASSED in 29.6s
//java/test/org/openqa/selenium/bidi/network:NetworkEventsTest-edge-remote PASSED in 35.5s

    @shbenzer shbenzer merged commit 4dab85c into SeleniumHQ:trunk Apr 24, 2025
    10 of 11 checks passed
    @Delta456 Delta456 deleted the edge_network_bidi_tests branch April 24, 2025 18:22
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @shbenzer shbenzer shbenzer approved these changes

    @pujagani pujagani Awaiting requested review from pujagani

    Assignees

    No one assigned

    Labels

    B-build Includes scripting, bazel and CI integrations B-devtools Includes everything BiDi or Chrome DevTools related C-java Java Bindings Review effort 1/5

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    3 participants

    @Delta456 @shbenzer @selenium-ci