From e589c65e2eefb48ac94bab7259758a35d392199d Mon Sep 17 00:00:00 2001 From: Navin Chandra Date: Fri, 25 Apr 2025 11:09:30 +0530 Subject: [PATCH 1/3] enable tests for bidi storage (edge) and permissions --- java/test/org/openqa/selenium/bidi/permissions/BUILD.bazel | 2 ++ java/test/org/openqa/selenium/bidi/storage/BUILD.bazel | 1 + .../openqa/selenium/bidi/storage/StorageCommandsTest.java | 7 ------- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/java/test/org/openqa/selenium/bidi/permissions/BUILD.bazel b/java/test/org/openqa/selenium/bidi/permissions/BUILD.bazel index 33e1bdfd8451e..71bcd3355b2fc 100644 --- a/java/test/org/openqa/selenium/bidi/permissions/BUILD.bazel +++ b/java/test/org/openqa/selenium/bidi/permissions/BUILD.bazel @@ -7,6 +7,8 @@ java_selenium_test_suite( srcs = glob(["*Test.java"]), browsers = [ "firefox", + "chrome", + "edge", ], data = [ "//third_party/chrome_ext:backspace.crx", diff --git a/java/test/org/openqa/selenium/bidi/storage/BUILD.bazel b/java/test/org/openqa/selenium/bidi/storage/BUILD.bazel index 96db6d7d060d2..b631b5e11cb16 100644 --- a/java/test/org/openqa/selenium/bidi/storage/BUILD.bazel +++ b/java/test/org/openqa/selenium/bidi/storage/BUILD.bazel @@ -8,6 +8,7 @@ java_selenium_test_suite( browsers = [ "chrome", "firefox", + "edge", ], tags = [ "selenium-remote", diff --git a/java/test/org/openqa/selenium/bidi/storage/StorageCommandsTest.java b/java/test/org/openqa/selenium/bidi/storage/StorageCommandsTest.java index e3cccf69209c4..257cde6f0cc77 100644 --- a/java/test/org/openqa/selenium/bidi/storage/StorageCommandsTest.java +++ b/java/test/org/openqa/selenium/bidi/storage/StorageCommandsTest.java @@ -63,7 +63,6 @@ public void setUp() { } @Test - @NotYetImplemented(EDGE) public void canGetCookieByName() { String key = generateUniqueKey(); String value = "set"; @@ -124,7 +123,6 @@ public void canGetCookieInDefaultUserContext() { } @Test - @NotYetImplemented(EDGE) public void canGetCookieInAUserContext() { Browser browser = new Browser(driver); String userContext = browser.createUserContext(); @@ -177,7 +175,6 @@ key, new BytesValue(BytesValue.Type.STRING, value), appServer.getHostName()), } @Test - @NotYetImplemented(EDGE) public void canAddCookie() { String key = generateUniqueKey(); String value = "foo"; @@ -261,7 +258,6 @@ public void canAddAndGetCookie() { } @Test - @NotYetImplemented(EDGE) public void canGetAllCookies() { String key1 = generateUniqueKey(); String key2 = generateUniqueKey(); @@ -289,7 +285,6 @@ public void canGetAllCookies() { } @Test - @NotYetImplemented(EDGE) public void canDeleteAllCookies() { addCookieOnServerSide(new Cookie("foo", "set")); assertSomeCookiesArePresent(); @@ -303,7 +298,6 @@ public void canDeleteAllCookies() { } @Test - @NotYetImplemented(EDGE) public void canDeleteCookieWithName() { String key1 = generateUniqueKey(); String key2 = generateUniqueKey(); @@ -325,7 +319,6 @@ public void canDeleteCookieWithName() { } @Test - @NotYetImplemented(EDGE) public void testAddCookiesWithDifferentPathsThatAreRelatedToOurs() { driver.get(appServer.whereIs("/common/animals")); From 1a3f02bae2ecddaf46026727b3cf4ad91d94952b Mon Sep 17 00:00:00 2001 From: Navin Chandra Date: Fri, 25 Apr 2025 15:33:29 +0530 Subject: [PATCH 2/3] skip `canGetAllCookies()` test in edge --- .../org/openqa/selenium/bidi/storage/StorageCommandsTest.java | 1 + 1 file changed, 1 insertion(+) diff --git a/java/test/org/openqa/selenium/bidi/storage/StorageCommandsTest.java b/java/test/org/openqa/selenium/bidi/storage/StorageCommandsTest.java index 257cde6f0cc77..c898f63737d49 100644 --- a/java/test/org/openqa/selenium/bidi/storage/StorageCommandsTest.java +++ b/java/test/org/openqa/selenium/bidi/storage/StorageCommandsTest.java @@ -258,6 +258,7 @@ public void canAddAndGetCookie() { } @Test + @NotYetImplemented(EDGE) public void canGetAllCookies() { String key1 = generateUniqueKey(); String key2 = generateUniqueKey(); From 3e835bc91811548b4194941fbdbc26cf13ebde65 Mon Sep 17 00:00:00 2001 From: Navin Chandra Date: Mon, 28 Apr 2025 18:05:36 +0530 Subject: [PATCH 3/3] remove chrome and edge for permissions test --- java/test/org/openqa/selenium/bidi/permissions/BUILD.bazel | 2 -- 1 file changed, 2 deletions(-) diff --git a/java/test/org/openqa/selenium/bidi/permissions/BUILD.bazel b/java/test/org/openqa/selenium/bidi/permissions/BUILD.bazel index 71bcd3355b2fc..33e1bdfd8451e 100644 --- a/java/test/org/openqa/selenium/bidi/permissions/BUILD.bazel +++ b/java/test/org/openqa/selenium/bidi/permissions/BUILD.bazel @@ -7,8 +7,6 @@ java_selenium_test_suite( srcs = glob(["*Test.java"]), browsers = [ "firefox", - "chrome", - "edge", ], data = [ "//third_party/chrome_ext:backspace.crx",