Skip to content

[java] Removing deprecated items in Require.java #15711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2025
Merged

[java] Removing deprecated items in Require.java #15711

merged 1 commit into from
May 7, 2025

Conversation

@diemol
Copy link
Member

@diemol diemol commented May 7, 2025 •
edited by qodo-merge-pro bot
Loading

User description

🔗 Related Issues

None

💥 What does this PR do?

Removing deprecated items for a long time in the Require internal class.

🔧 Implementation Notes

💡 Additional Considerations

🔄 Types of changes

  • Cleanup (formatting, renaming)
  • Bug fix (backwards compatible)
  • New feature (non-breaking change which adds functionality and tests!)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR Type

Enhancement

Description

  • Remove deprecated FileChecker and FileStateChecker classes

  • Eliminate deprecated file-related argument and state methods

  • Clean up imports and internal API surface

Changes walkthrough 📝

Relevant files
I-cleanup
Require.java
Remove deprecated file-based checkers and methods               

java/src/org/openqa/selenium/internal/Require.java

  • Removed deprecated FileChecker and FileStateChecker classes
  • Deleted deprecated argument and state methods for File
  • Cleaned up unused imports related to File
  • Updated internal API to rely on Path-based checks
    		• +0/-105 
    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
    •

    @selenium-ci selenium-ci added the C-java Java Bindings label May 7, 2025
    @qodo-merge-pro
    Copy link
    Contributor

    qodo-merge-pro bot commented May 7, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    🎫 Ticket compliance analysis ❌

    1234 - Not compliant

    Non-compliant requirements:

    • Fix issue where JavaScript in link's href is not triggered on click() in Firefox 42.0 with Selenium 2.48.0/2.48.2
    • Ensure compatibility with Firefox 42.0 32bit on 64bit machine

    5678 - Not compliant

    Non-compliant requirements:

    • Fix "Error: ConnectFailure (Connection refused)" when instantiating ChromeDriver after the first instance
    • Ensure compatibility with Chrome 65.0.3325.181 and ChromeDriver 2.35
    • Fix issues on Ubuntu 16.04.4 with Linux 4.10.0 and Selenium 3.9.0

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    @qodo-merge-pro
    Copy link
    Contributor

    qodo-merge-pro bot commented May 7, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @diemol diemol merged commit 51083a8 into trunk May 7, 2025
    36 checks passed
    @diemol diemol deleted the remove_deprecated_in_require branch May 7, 2025 11:59
    This was referenced Sep 12, 2025
    Closed
    Closed
    Merged
    This was referenced Sep 19, 2025
    Closed
    Closed
    Closed
    This was referenced Oct 1, 2025
    Closed
    Closed
    Closed
    @dependabot dependabot bot mentioned this pull request Oct 24, 2025
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    No reviews

    Assignees

    No one assigned

    Labels

    C-java Java Bindings Review effort 1/5

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    3 participants

    @diemol @selenium-ci