Skip to content
Merged
Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
bb64a90
[py] Add ruff linter/formatter and fix violations
cgoldberg May 5, 2025
119181e
Merge branch 'SeleniumHQ:trunk' into py-ruff
cgoldberg May 6, 2025
cd40251
Merge branch 'SeleniumHQ:trunk' into py-ruff
cgoldberg May 6, 2025
d5f6d35
Merge branch 'SeleniumHQ:trunk' into py-ruff
cgoldberg May 7, 2025
34286e9
Merge branch 'SeleniumHQ:trunk' into py-ruff
cgoldberg May 10, 2025
a61cadf
Merge branch 'SeleniumHQ:trunk' into py-ruff
cgoldberg May 11, 2025
80bd62f
Merge branch 'SeleniumHQ:trunk' into py-ruff
cgoldberg May 11, 2025
0207e95
Merge branch 'SeleniumHQ:trunk' into py-ruff
cgoldberg May 13, 2025
b502193
Merge branch 'SeleniumHQ:trunk' into py-ruff
cgoldberg May 14, 2025
4a6bf9e
Merge branch 'SeleniumHQ:trunk' into py-ruff
cgoldberg May 15, 2025
d54aacf
Merge branch 'SeleniumHQ:trunk' into py-ruff
cgoldberg May 15, 2025
e07e050
Merge branch 'SeleniumHQ:trunk' into py-ruff
cgoldberg May 15, 2025
04791a7
[py] Remove old linters and add ruff
cgoldberg May 16, 2025
24d0194
[py] Fix the rest of the linting errors
cgoldberg May 16, 2025
95b5594
[py] Remove docformatter and update README.md
cgoldberg May 16, 2025
9aa794f
[py] Fix docstring
cgoldberg May 16, 2025
780297e
[py] Remove comments
cgoldberg May 16, 2025
1797093
[py] Plug-in ruff into Bazel
p0deje May 16, 2025
1db60e9
[py] Update readme
p0deje May 16, 2025
b244b2c
Merge branch 'SeleniumHQ:trunk' into py-ruff
cgoldberg May 16, 2025
fb7f0f1
[py] Add import sorting
cgoldberg May 16, 2025
6ae2f4c
[py] Remove docformatter from tox
cgoldberg May 16, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/ci-python.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,7 @@ jobs:
- name: Test with tox
run: tox -c py/tox.ini
env:
# If this fails, it will exit. Local work should be using `tox -e linting` prior to committing.
# the linting-ci recipe exists solely for CI and will not attempt to rewrite any files in-place etc.
TOXENV: linting-ci
TOXENV: linting

mypy:
name: Mypy
Expand Down
10 changes: 3 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -217,16 +217,12 @@ To automatically update and pin new dependencies, run:

### Python

#### Linting
#### Linting and Formatting

We follow the [PEP8 Style Guide for Python Code](https://peps.python.org/pep-0008) (except we use a 120 character line length).
This is checked and enforced with several linting tools, including
[black](https://pypi.org/project/black),
[docformatter](https://pypi.org/project/docformatter),
[flake8](https://flake8.pycqa.org),
and [isort](https://pycqa.github.io/isort).
This is checked and enforced with [ruff](https://docs.astral.sh/ruff/), a linting/formatting tool.

To run all of the linting tools:
To run linting and formatting:
```shell
./go py:lint
```
Expand Down
144 changes: 78 additions & 66 deletions py/docs/source/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,100 +29,108 @@
# -- General configuration -----------------------------------------------------

# If your documentation needs a minimal Sphinx version, state it here.
#needs_sphinx = '1.0'
# needs_sphinx = '1.0'

# Add any Sphinx extension module names here, as strings. They can be extensions
# coming with Sphinx (named 'sphinx.ext.*') or your custom ones.
extensions = ['sphinx.ext.autodoc', 'sphinx.ext.autosummary', 'sphinx.ext.doctest', 'sphinx.ext.todo', 'sphinx.ext.coverage', 'sphinx.ext.imgmath', 'sphinx.ext.viewcode']
extensions = [
"sphinx.ext.autodoc",
"sphinx.ext.autosummary",
"sphinx.ext.doctest",
"sphinx.ext.todo",
"sphinx.ext.coverage",
"sphinx.ext.imgmath",
"sphinx.ext.viewcode",
]

# Add any paths that contain templates here, relative to this directory.
templates_path = ['_templates']
templates_path = ["_templates"]

# The suffix of source filenames.
source_suffix = '.rst'
source_suffix = ".rst"

# The encoding of source files.
#source_encoding = 'utf-8-sig'
# source_encoding = 'utf-8-sig'

# The master toctree document.
master_doc = 'index'
master_doc = "index"

# General information about the project.
project = 'Selenium'
copyright = '2009-2025 Software Freedom Conservancy'
project = "Selenium"
copyright = "2009-2025 Software Freedom Conservancy"

# The version info for the project you're documenting, acts as replacement for
# |version| and |release|, also used in various other places throughout the
# built documents.
#
# The short X.Y version.
version = '4.33'
version = "4.33"
# The full version, including alpha/beta/rc tags.
release = '4.33.0.202505022255'
release = "4.33.0.202505022255"

# The language for content autogenerated by Sphinx. Refer to documentation
# for a list of supported languages.
#language = None
# language = None

# There are two options for replacing |today|: either, you set today to some
# non-false value, then it is used:
#today = ''
# today = ''
# Else, today_fmt is used as the format for a strftime call.
#today_fmt = '%B %d, %Y'
# today_fmt = '%B %d, %Y'

# List of patterns, relative to source directory, that match files and
# directories to ignore when looking for source files.
exclude_patterns = []

# The reST default role (used for this markup: `text`) to use for all documents.
#default_role = None
# default_role = None

# If true, '()' will be appended to :func: etc. cross-reference text.
#add_function_parentheses = True
# add_function_parentheses = True

# If true, the current module name will be prepended to all description
# unit titles (such as .. function::).
#add_module_names = True
# add_module_names = True

# If true, sectionauthor and moduleauthor directives will be shown in the
# output. They are ignored by default.
#show_authors = False
# show_authors = False

# The name of the Pygments (syntax highlighting) style to use.
pygments_style = 'sphinx'
pygments_style = "sphinx"

# A list of ignored prefixes for module index sorting.
#modindex_common_prefix = []
# modindex_common_prefix = []


# -- Options for HTML output ---------------------------------------------------

# The theme to use for HTML and HTML Help pages
html_theme = 'sphinx_material'
html_theme = "sphinx_material"

# Theme options are theme-specific and customize the look and feel of a theme
# further. For a list of options available for each theme, see the
# documentation.
#html_theme_options = {}
# html_theme_options = {}

# Add any paths that contain custom themes here, relative to this directory.
#html_theme_path = []
# html_theme_path = []

# The name for this set of Sphinx documents. If None, it defaults to
# "<project> v<release> documentation".
#html_title = None
# html_title = None

# A shorter title for the navigation bar. Default is the same as html_title.
#html_short_title = None
# html_short_title = None

# The name of an image file (relative to this directory) to place at the top
# of the sidebar.
#html_logo = ''
# html_logo = ''

# The name of an image file (within the static path) to use as favicon of the
# docs. This file should be a Windows icon file (.ico) being 16x16 or 32x32
# pixels large.
#html_favicon = None
# html_favicon = None

# Add any paths that contain custom static files (such as style sheets) here,
# relative to this directory. They are copied after the builtin static files,
Expand All @@ -131,18 +139,18 @@

# If not '', a 'Last updated on:' timestamp is inserted at every page bottom,
# using the given strftime format.
#html_last_updated_fmt = '%b %d, %Y'
# html_last_updated_fmt = '%b %d, %Y'

# If true, SmartyPants will be used to convert quotes and dashes to
# typographically correct entities.
#html_use_smartypants = True
# html_use_smartypants = True

# Custom sidebar templates, maps document names to template names.
#html_sidebars = {}
# html_sidebars = {}

# Additional templates that should be rendered to pages, maps page names to
# template names.
#html_additional_pages = {}
# html_additional_pages = {}

# If false, no module index is generated.
html_domain_indices = True
Expand All @@ -160,122 +168,126 @@
html_show_sphinx = False

# If true, "(C) Copyright ..." is shown in the HTML footer. Default is True.
#html_show_copyright = True
# html_show_copyright = True

# If true, an OpenSearch description file will be output, and all pages will
# contain a <link> tag referring to it. The value of this option must be the
# base URL from which the finished HTML is served.
#html_use_opensearch = ''
# html_use_opensearch = ''

# This is the file name suffix for HTML files (e.g. ".xhtml").
#html_file_suffix = None
# html_file_suffix = None

# Output file base name for HTML help builder.
htmlhelp_basename = 'Seleniumdoc'
htmlhelp_basename = "Seleniumdoc"


# -- Options for LaTeX output --------------------------------------------------

# The paper size ('letter' or 'a4').
#latex_paper_size = 'letter'
# latex_paper_size = 'letter'

# The font size ('10pt', '11pt' or '12pt').
#latex_font_size = '10pt'
# latex_font_size = '10pt'

# Grouping the document tree into LaTeX files. List of tuples
# (source start file, target name, title, author, documentclass [howto/manual]).
latex_documents = [
('index', 'Selenium.tex', 'Selenium Documentation',
'plightbo, simon.m.stewart, hbchai, jrhuggins, et al.', 'manual'),
(
"index",
"Selenium.tex",
"Selenium Documentation",
"plightbo, simon.m.stewart, hbchai, jrhuggins, et al.",
"manual",
),
]

# The name of an image file (relative to this directory) to place at the top of
# the title page.
#latex_logo = None
# latex_logo = None

# For "manual" documents, if this is true, then toplevel headings are parts,
# not chapters.
#latex_use_parts = False
# latex_use_parts = False

# If true, show page references after internal links.
#latex_show_pagerefs = False
# latex_show_pagerefs = False

# If true, show URL addresses after external links.
#latex_show_urls = False
# latex_show_urls = False

# Additional stuff for the LaTeX preamble.
#latex_preamble = ''
# latex_preamble = ''

# Documents to append as an appendix to all manuals.
#latex_appendices = []
# latex_appendices = []

# If false, no module index is generated.
#latex_domain_indices = True
# latex_domain_indices = True


# -- Options for manual page output --------------------------------------------

# One entry per manual page. List of tuples
# (source start file, name, description, authors, manual section).
man_pages = [
('index', 'selenium', 'Selenium Documentation',
['plightbo, simon.m.stewart, hbchai, jrhuggins, et al.'], 1)
("index", "selenium", "Selenium Documentation", ["plightbo, simon.m.stewart, hbchai, jrhuggins, et al."], 1)
]


# -- Options for Epub output ---------------------------------------------------

# Bibliographic Dublin Core info.
epub_title = 'Selenium'
epub_author = 'The Selenium Project'
epub_publisher = 'The Selenium Project'
epub_copyright = '2009-2024 Software Freedom Conservancy'
epub_title = "Selenium"
epub_author = "The Selenium Project"
epub_publisher = "The Selenium Project"
epub_copyright = "2009-2024 Software Freedom Conservancy"

# The language of the text. It defaults to the language option
# or en if the language is not set.
#epub_language = ''
# epub_language = ''

# The scheme of the identifier. Typical schemes are ISBN or URL.
#epub_scheme = ''
# epub_scheme = ''

# The unique identifier of the text. This can be a ISBN number
# or the project homepage.
#epub_identifier = ''
# epub_identifier = ''

# A unique identification for the text.
#epub_uid = ''
# epub_uid = ''

# HTML files that should be inserted before the pages created by sphinx.
# The format is a list of tuples containing the path and title.
#epub_pre_files = []
# epub_pre_files = []

# HTML files that should be inserted after the pages created by sphinx.
# The format is a list of tuples containing the path and title.
#epub_post_files = []
# epub_post_files = []

# A list of files that should not be packed into the epub file.
#epub_exclude_files = []
# epub_exclude_files = []

# The depth of the table of contents in toc.ncx.
#epub_tocdepth = 3
# epub_tocdepth = 3

# Allow duplicate toc entries.
#epub_tocdup = True
# epub_tocdup = True


# Example configuration for intersphinx: refer to the Python standard library.
intersphinx_mapping = {'http://docs.python.org/': None}
intersphinx_mapping = {"http://docs.python.org/": None}

# 'members' includes anything that has a docstring, 'undoc-members' includes
# functions without docstrings.
autodoc_default_flags = ['members', 'undoc-members']
autodoc_default_flags = ["members", "undoc-members"]

# configuration for keeping the methods that can be invoked on said classes
autodoc_default_options = {
'members': True,
'member-order': 'bysource',
'undoc-members': True,
'inherited-members': True,
"members": True,
"member-order": "bysource",
"undoc-members": True,
"inherited-members": True,
}

# Include __init__ comments
Expand Down
Loading
Loading