Skip to content

[py] Fix possible TypeError in expected conditions #15891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 13, 2025
Merged

[py] Fix possible TypeError in expected conditions #15891

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
61d8a00
[py] Fix : mypy type errors
ShauryaDusht Jun 12, 2025
11527ec
changes : empty str condition
ShauryaDusht Jun 12, 2025
1910eb3
Merge branch 'trunk' into fix-mypy-type-errors-3
cgoldberg Jun 12, 2025
fc48ea4
Merge branch 'trunk' into fix-mypy-type-errors-3
cgoldberg Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions py/selenium/webdriver/support/expected_conditions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,6 +428,8 @@ def text_to_be_present_in_element_value(
def _predicate(driver: WebDriverOrWebElement):
try:
element_text = driver.find_element(*locator).get_attribute("value")
if element_text is None:
return False
return text_ in element_text
except StaleElementReferenceException:
return False
Expand Down