From 23494c82515855e9bda2626a393c97a0d9d031d8 Mon Sep 17 00:00:00 2001 From: Alex Popov Date: Fri, 20 Jun 2025 23:57:26 +0700 Subject: [PATCH 1/2] add deprecation warn for ftp proxy type --- rb/lib/selenium/webdriver/common/proxy.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/rb/lib/selenium/webdriver/common/proxy.rb b/rb/lib/selenium/webdriver/common/proxy.rb index 9ea94c0dfb294..921be998fe8b7 100644 --- a/rb/lib/selenium/webdriver/common/proxy.rb +++ b/rb/lib/selenium/webdriver/common/proxy.rb @@ -77,6 +77,7 @@ def ==(other) alias eql? == def ftp=(value) + warn "[DEPRECATED] FTP proxy support is deprecated and will be removed in the 4.37 version." self.type = :manual @ftp = value end From 571532b5c85466f7d834b7615eb24cbf0b125fbb Mon Sep 17 00:00:00 2001 From: Alex Popov Date: Sat, 21 Jun 2025 00:10:09 +0700 Subject: [PATCH 2/2] [proxy] Replace deprecation warning for FTP proxy support with logger method --- rb/lib/selenium/webdriver/common/proxy.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rb/lib/selenium/webdriver/common/proxy.rb b/rb/lib/selenium/webdriver/common/proxy.rb index 921be998fe8b7..644511575915e 100644 --- a/rb/lib/selenium/webdriver/common/proxy.rb +++ b/rb/lib/selenium/webdriver/common/proxy.rb @@ -77,7 +77,7 @@ def ==(other) alias eql? == def ftp=(value) - warn "[DEPRECATED] FTP proxy support is deprecated and will be removed in the 4.37 version." + WebDriver.logger.deprecate('FTP proxy support', nil, id: :ftp_proxy) self.type = :manual @ftp = value end