You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request includes a small change to the Keys enum in the Keys.java file. The change updates the Unicode value for the OPTION key to align with the WebDriver specification.
🔄 Types of changes
Bug fix (backwards compatible)
New feature (non-breaking change which adds functionality and tests!)
PR Type
Bug fix
Description
Fix Unicode value for OPTION key in Keys enum
Update from '\uE050' to '\uE052' to align with WebDriver specification
The OPTION key now uses the same Unicode value '\uE052' as RIGHT_ALT, which could cause conflicts or unexpected behavior when both keys need to be distinguished in keyboard actions.
RIGHT_ALT('\uE052'),
RIGHT_COMMAND('\uE053'),
// Symbolic macOS keys not yet standardizedOPTION('\uE052'), // TODO: verify Unicode value with WebDriver spec
The TODO comment suggests the Unicode value still needs verification with WebDriver spec, indicating this change might not be final or fully validated against the specification.
OPTION('\uE052'), // TODO: verify Unicode value with WebDriver specFN('\uE051'), // TODO: symbolic only; confirm or remove in future
The OPTION key now has the same Unicode value as RIGHT_ALT ('\uE052'), creating a duplicate mapping. This could cause ambiguity in key handling and unexpected behavior when both keys are used.
-OPTION('\uE052'), // TODO: verify Unicode value with WebDriver spec+OPTION('\uE054'), // TODO: verify Unicode value with WebDriver spec
Apply / Chat
Suggestion importance[1-10]: 7
__
Why: The suggestion correctly identifies that the PR introduces a duplicate Unicode value. The new value for OPTION (\uE052) is the same as for RIGHT_ALT. This could lead to ambiguity or unexpected behavior, so flagging it is a valid and helpful observation.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
🔗 Related Issues
fixes #15945 also fixes #15910
💥 What does this PR do?
Option key code fixed according to specification https://w3c.github.io/webdriver/#keyboard-actions
🔧 Implementation Notes
This pull request includes a small change to the
Keysenum in theKeys.javafile. The change updates the Unicode value for theOPTIONkey to align with the WebDriver specification.🔄 Types of changes
PR Type
Bug fix
Description
Fix Unicode value for OPTION key in Keys enum
Update from '\uE050' to '\uE052' to align with WebDriver specification
Resolves macOS keyboard action compatibility issues
Changes walkthrough 📝
Keys.java
Fix OPTION key Unicode valuejava/src/org/openqa/selenium/Keys.java