From 07eb5d4466c3a001f3cc82619fec64663a2aefad Mon Sep 17 00:00:00 2001 From: Navin Chandra Date: Tue, 1 Jul 2025 17:04:48 +0530 Subject: [PATCH 1/6] use pinned browsers in `ci-python.yml` --- .github/workflows/ci-python.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci-python.yml b/.github/workflows/ci-python.yml index 713ab6d884275..96bdbfefddf18 100644 --- a/.github/workflows/ci-python.yml +++ b/.github/workflows/ci-python.yml @@ -89,8 +89,8 @@ jobs: os: ${{ matrix.os }} cache-key: py-browser-${{ matrix.browser }} run: | - bazel test --local_test_jobs 1 --flaky_test_attempts 3 //py:common-${{ matrix.browser }}-bidi - bazel test --local_test_jobs 1 --flaky_test_attempts 3 //py:test-${{ matrix.browser }} + bazel test --local_test_jobs 1 --flaky_test_attempts 3 --pin_browsers=true //py:common-${{ matrix.browser }}-bidi + bazel test --local_test_jobs 1 --flaky_test_attempts 3 --pin_browsers=true //py:test-${{ matrix.browser }} safari-tests: name: Browser Tests @@ -108,4 +108,4 @@ jobs: os: ${{ matrix.os }} cache-key: py-browser-${{ matrix.browser }} run: | - bazel test --local_test_jobs 1 --flaky_test_attempts 3 //py:test-${{ matrix.browser }} + bazel test --local_test_jobs 1 --flaky_test_attempts 3 --pin_browsers=true //py:test-${{ matrix.browser }} From 9cd7126febfc4ba0ab2e2101f9ad0fd52b9ad1cd Mon Sep 17 00:00:00 2001 From: Navin Chandra Date: Tue, 1 Jul 2025 18:20:02 +0530 Subject: [PATCH 2/6] use pinned browsers in `ci-java.yml` --- .github/workflows/ci-java.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci-java.yml b/.github/workflows/ci-java.yml index 1ebd054c05089..6c0c72bd341c3 100644 --- a/.github/workflows/ci-java.yml +++ b/.github/workflows/ci-java.yml @@ -23,7 +23,7 @@ jobs: java-version: 17 run: | fsutil 8dot3name set 0 - bazel test --flaky_test_attempts 3 //java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest ` + bazel test --flaky_test_attempts 3 --pin_browsers=true //java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest ` //java/test/org/openqa/selenium/federatedcredentialmanagement:FederatedCredentialManagementTest ` //java/test/org/openqa/selenium/firefox:FirefoxDriverBuilderTest ` //java/test/org/openqa/selenium/grid/router:RemoteWebDriverDownloadTest ` @@ -47,7 +47,7 @@ jobs: # https://github.com/bazelbuild/rules_jvm_external/issues/1046 java-version: 17 run: | - bazel test --flaky_test_attempts 3 //java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest-remote \ + bazel test --flaky_test_attempts 3 --pin_browsers=true //java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest-remote \ //java/test/org/openqa/selenium/federatedcredentialmanagement:FederatedCredentialManagementTest \ //java/test/org/openqa/selenium/firefox:FirefoxDriverBuilderTest \ //java/test/org/openqa/selenium/grid/router:RemoteWebDriverDownloadTest \ @@ -71,4 +71,4 @@ jobs: # https://github.com/bazelbuild/rules_jvm_external/issues/1046 java-version: 17 run: | - bazel test --flaky_test_attempts 3 //java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest-remote + bazel test --flaky_test_attempts 3 --pin_browsers=true //java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest-remote From 5b0e5893f51d85fbb47d671b5cb18b2b830ec995 Mon Sep 17 00:00:00 2001 From: Navin Chandra Date: Tue, 1 Jul 2025 20:16:06 +0530 Subject: [PATCH 3/6] use pinned browsers for ruby windows --- .github/workflows/ci-ruby.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci-ruby.yml b/.github/workflows/ci-ruby.yml index 63aeb45c304ab..91bfc322ab9b4 100644 --- a/.github/workflows/ci-ruby.yml +++ b/.github/workflows/ci-ruby.yml @@ -84,7 +84,7 @@ jobs: --local_test_jobs 1 --test_size_filters large --test_tag_filters ${{ matrix.browser }} - ${{ matrix.os != 'windows' && '--pin_browsers' || '' }} + --pin_browsers //rb/spec/... integration-tests-remote: @@ -111,5 +111,5 @@ jobs: --local_test_jobs 1 --test_size_filters large --test_tag_filters ${{ matrix.browser }}-remote - ${{ matrix.os != 'windows' && '--pin_browsers' || '' }} + --pin_browsers //rb/spec/... From da15f5afc09c7ccf61094d8f6c7827aebbf36c65 Mon Sep 17 00:00:00 2001 From: Navin Chandra Date: Tue, 1 Jul 2025 20:19:51 +0530 Subject: [PATCH 4/6] trigger CI From 773e6eb274676a98bebdb4cf22399d0173c1e14a Mon Sep 17 00:00:00 2001 From: Navin Chandra Date: Tue, 1 Jul 2025 21:21:09 +0530 Subject: [PATCH 5/6] ignore java fedcm tests --- .../FederatedCredentialManagementTest.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/java/test/org/openqa/selenium/federatedcredentialmanagement/FederatedCredentialManagementTest.java b/java/test/org/openqa/selenium/federatedcredentialmanagement/FederatedCredentialManagementTest.java index f6690f388aa00..582f8e8a70c1f 100644 --- a/java/test/org/openqa/selenium/federatedcredentialmanagement/FederatedCredentialManagementTest.java +++ b/java/test/org/openqa/selenium/federatedcredentialmanagement/FederatedCredentialManagementTest.java @@ -39,6 +39,7 @@ import org.openqa.selenium.environment.InProcessTestEnvironment; import org.openqa.selenium.environment.webserver.AppServer; import org.openqa.selenium.support.ui.WebDriverWait; +import org.openqa.selenium.testing.Ignore; class FederatedCredentialManagementTest { @@ -87,6 +88,7 @@ private void waitForDialog() { } @Test + @Ignore(value = CHROME, reason = "https://issues.chromium.org/u/0/issues/425801332") void testDismissDialog() { fedcmDriver.setDelayEnabled(false); assertNull(fedcmDriver.getFederatedCredentialManagementDialog()); @@ -110,6 +112,7 @@ void testDismissDialog() { } @Test + @Ignore(value = CHROME, reason = "https://issues.chromium.org/u/0/issues/425801332") void testSelectAccount() { assertNull(fedcmDriver.getFederatedCredentialManagementDialog()); @@ -130,6 +133,7 @@ void testSelectAccount() { } @Test + @Ignore(value = CHROME, reason = "https://issues.chromium.org/u/0/issues/425801332") void testGetAccounts() { assertNull(fedcmDriver.getFederatedCredentialManagementDialog()); From 6382f580e210fa37e8ee30ba4145a62da10b7a15 Mon Sep 17 00:00:00 2001 From: Navin Chandra Date: Wed, 2 Jul 2025 12:46:21 +0530 Subject: [PATCH 6/6] disable java fedcm tests --- .../FederatedCredentialManagementTest.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/java/test/org/openqa/selenium/federatedcredentialmanagement/FederatedCredentialManagementTest.java b/java/test/org/openqa/selenium/federatedcredentialmanagement/FederatedCredentialManagementTest.java index 582f8e8a70c1f..ee9a6658cd338 100644 --- a/java/test/org/openqa/selenium/federatedcredentialmanagement/FederatedCredentialManagementTest.java +++ b/java/test/org/openqa/selenium/federatedcredentialmanagement/FederatedCredentialManagementTest.java @@ -29,6 +29,7 @@ import java.util.List; import org.junit.jupiter.api.AfterEach; import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.Test; import org.openqa.selenium.By; import org.openqa.selenium.NoAlertPresentException; @@ -39,8 +40,8 @@ import org.openqa.selenium.environment.InProcessTestEnvironment; import org.openqa.selenium.environment.webserver.AppServer; import org.openqa.selenium.support.ui.WebDriverWait; -import org.openqa.selenium.testing.Ignore; +@Disabled("https://issues.chromium.org/u/0/issues/425801332") class FederatedCredentialManagementTest { private HasFederatedCredentialManagement fedcmDriver; @@ -88,7 +89,6 @@ private void waitForDialog() { } @Test - @Ignore(value = CHROME, reason = "https://issues.chromium.org/u/0/issues/425801332") void testDismissDialog() { fedcmDriver.setDelayEnabled(false); assertNull(fedcmDriver.getFederatedCredentialManagementDialog()); @@ -112,7 +112,6 @@ void testDismissDialog() { } @Test - @Ignore(value = CHROME, reason = "https://issues.chromium.org/u/0/issues/425801332") void testSelectAccount() { assertNull(fedcmDriver.getFederatedCredentialManagementDialog()); @@ -133,7 +132,6 @@ void testSelectAccount() { } @Test - @Ignore(value = CHROME, reason = "https://issues.chromium.org/u/0/issues/425801332") void testGetAccounts() { assertNull(fedcmDriver.getFederatedCredentialManagementDialog());