Skip to content

Conversation

@iampopovich
Copy link
Contributor

@iampopovich iampopovich commented Jul 7, 2025

User description

🔗 Related Issues

fixes #10397

💥 What does this PR do?

This pull request removes several commands related to local storage and session storage from the webdriver.CommandName object in javascript/webdriver/command.js. These changes streamline the CommandName definitions by eliminating unused or deprecated commands.

Key changes:

Removal of local storage commands:

  • Removed commands for interacting with local storage, including getting items, keys, and size, setting items, removing items, and clearing storage.

Removal of session storage commands:

  • Removed commands for interacting with session storage, including getting items, keys, and size, setting items, removing items, and clearing storage.

🔧 Implementation Notes

💡 Additional Considerations

🔄 Types of changes

  • Cleanup (formatting, renaming)

PR Type

Other


Description

  • Remove obsolete local storage command names

  • Remove obsolete session storage command names

  • Clean up deprecated HTML5 storage commands


Changes diagram

flowchart LR
  A["webdriver.CommandName"] --> B["Remove Local Storage Commands"]
  A --> C["Remove Session Storage Commands"]
  B --> D["Cleaned Command Object"]
  C --> D
Loading

Changes walkthrough 📝

Relevant files
Cleanup
command.js
Remove obsolete storage commands                                                 

javascript/webdriver/command.js

  • Removed 6 local storage command definitions
  • Removed 6 session storage command definitions
  • Cleaned up obsolete HTML5 storage commands
  • +1/-13   

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @qodo-merge-pro
    Copy link
    Contributor

    qodo-merge-pro bot commented Jul 7, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Code Formatting

    An empty line was added at line 186 which appears to be unintentional and creates inconsistent spacing in the command definitions object.

    @qodo-merge-pro
    Copy link
    Contributor

    qodo-merge-pro bot commented Jul 7, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @pujagani
    Copy link
    Contributor

    pujagani commented Aug 5, 2025

    Did we deprecate before removal? Just curious

    @iampopovich
    Copy link
    Contributor Author

    Did we deprecate before removal

    My motivation: I saw a TODO to remove obsolete commands here

    // TODO: Delete obsolete command names.
    so I decided that there is no need to deprecate them, just remove them.

    I also searched for the use of these commands in the code in the trunk branch and did not find any obvious references to the variables.

    I think the change can cause bugs for users of the binding if they use command execution, like here driver.execute(webdriver.CommandName.REFRESH);

    Should I change the change to deprecate these variables? It will be possible to remove them after the release
    Screenshot 2025-08-07 012952

    @iampopovich
    Copy link
    Contributor Author

    @cgoldberg @pujagani check please 🙏

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    Remove HTML 5 functionality helper code

    3 participants