Skip to content

Fix typos in java & scripts #16021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix typos in java & scripts #16021

wants to merge 1 commit into from

Conversation

@noritaka1166
Copy link
Contributor

@noritaka1166 noritaka1166 commented Jul 8, 2025 •
edited by qodo-merge-pro bot
Loading

User description

🔗 Related Issues

💥 What does this PR do?

Fix typos in java & scripts

🔧 Implementation Notes

💡 Additional Considerations

🔄 Types of changes

PR Type

Other

Description

  • Fix typos in Java documentation and comments

  • Correct spelling in shell script comments

  • Update method parameter documentation

Changes diagram

flowchart LR
  A["Java files"] --> B["Fix documentation typos"]
  C["Shell script"] --> D["Fix comment typos"]
  B --> E["Improved code readability"]
  D --> E
Loading

Changes walkthrough 📝

Relevant files
Documentation
JsonOutput.java
Fix JavaDoc typo for indentation                                                 

java/src/org/openqa/selenium/json/JsonOutput.java

  • Fix typo in JavaDoc comment: "indention" → "indentation"
 +1/-1     
RetryRequest.java
Fix comment typo for perform                                                         

java/src/org/openqa/selenium/remote/http/RetryRequest.java

  • Fix typo in code comment: "preform" → "perform"
 +1/-1     
Wait.java
Fix JavaDoc typo for implementer                                                 

java/src/org/openqa/selenium/support/ui/Wait.java

  • Fix typo in JavaDoc comment: "implementor" → "implementer"
 +1/-1     
update_py_dependencies.sh
Fix shell script comment typo                                                       

scripts/update_py_dependencies.sh

  • Fix typo in script comment: "dependendencies" → "dependencies"
 +1/-1     
Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
    •

    @selenium-ci selenium-ci added C-java Java Bindings B-build Includes scripting, bazel and CI integrations B-support Issue or PR related to support classes labels Jul 8, 2025
    @selenium-ci
    Copy link
    Member

    selenium-ci commented Jul 8, 2025

    Thank you, @noritaka1166 for this code suggestion.

    The support packages contain example code that many users find helpful, but they do not necessarily represent
    the best practices for using Selenium, and the Selenium team is not currently merging changes to them.

    We actively encourage people to add the wrapper and helper code that makes sense for them to their own frameworks.
    If you have any questions, please contact us

    @selenium-ci selenium-ci closed this Jul 8, 2025
    @qodo-merge-pro
    Copy link
    Contributor

    qodo-merge-pro bot commented Jul 8, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    🎫 Ticket compliance analysis ❌

    5678 - Not compliant

    Non-compliant requirements:

    • Fix ChromeDriver connection failure error that occurs after first instance
    • Resolve "ConnectFailure (Connection refused)" error for subsequent ChromeDriver instances
    • Ensure proper ChromeDriver instantiation on Ubuntu 16.04.4 with Chrome 65.0.3325.181

    1234 - Not compliant

    Non-compliant requirements:

    • Fix JavaScript execution in link href on click() method for Selenium 2.48
    • Ensure JavaScript alerts are triggered when clicking links with JavaScript in href
    • Restore functionality that worked in version 2.47.1 but broke in 2.48.0 and 2.48.2
    • Fix compatibility with Firefox 42.0

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Typo Introduction

    The fix introduces a new typo "br" instead of "be" in the JavaDoc comment while fixing the original "indention" to "indentation" typo.

     
    * Specify whether the serialized JSON object should br formatted with line breaks and indentation
* ("pretty printed").

    @qodo-merge-pro
    Copy link
    Contributor

    qodo-merge-pro bot commented Jul 8, 2025

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    General
    Fix typo in JavaDoc comment

    There's a typo in the JavaDoc comment where "br" should be "be". This affects
    the readability and professionalism of the documentation.

    java/src/org/openqa/selenium/json/JsonOutput.java [267]

    -* Specify whether the serialized JSON object should br formatted with line breaks and indentation
+* Specify whether the serialized JSON object should be formatted with line breaks and indentation
    • Apply / Chat
    Suggestion importance[1-10]: 4

    __

    Why: The suggestion correctly identifies a typo (br instead of be) in the new Javadoc comment, which the PR author missed while fixing another typo in the same line.

    		Low
    • More

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    No reviews

    Assignees

    No one assigned

    Labels

    B-build Includes scripting, bazel and CI integrations B-support Issue or PR related to support classes C-java Java Bindings Review effort 1/5

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    2 participants

    @noritaka1166 @selenium-ci