-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[rust] Test Selenium Manager on Linux arm64 #16044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rust] Test Selenium Manager on Linux arm64 #16044
Conversation
Now that GitHub-hosted Linux arm64 runners are available, we can start using them to test the Selenium Manager code.
PR Reviewer Guide 🔍(Review updated until commit a88d4e1)Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Latest suggestions up to a88d4e1
Previous suggestionsSuggestions up to commit 19d72d6
|
||||||||||||||||||
Currently, only Firefox and Geckodriver have official support for Linux arm64. This commit ensures that the Selenium Manager test suite passes on this platform, by skipping tests on non- Firefox browsers.
19d72d6 to
a88d4e1
Compare
User description
🔗 Related Issues
#15801
💥 What does this PR do?
This PR ensures that the Selenium Manager test suite passes on Linux arm64, and enables CI tests for this platform through GitHub's recently released Linux arm64 runners.
🔧 Implementation Notes
I'm new to Rust, but wanted Selenium Manager to explicitly fail if users try to run it for Chrome or Edge on Linux arm64, since it's not supported. Previously, the code would silently download
linux64binaries which are for Linux x64, and cause segfaults on Linux arm64.The setup I went for at least ensures that Firefox/Geckodriver on Linux arm64 will work and are tested properly as well.
💡 Additional Considerations
The docs at https://www.selenium.dev/documentation/selenium_manager/#alternative-architectures will need to be updated if the team is open to merging this PR. I'm happy to open a separate PR for that if desired.
🔄 Types of changes
PR Type
Enhancement
Description
Add Linux ARM64 support for Selenium Manager
Enable CI testing on GitHub's ARM64 runners
Restrict Chrome/Edge to Firefox-only on ARM64
Update test suite for ARM64 compatibility
Changes diagram
Changes walkthrough 📝
2 files
Add ARM64 unsupported error for ChromeAdd ARM64 unsupported error for Edge11 files
Skip non-Firefox tests on ARM64Skip non-Firefox browser tests on ARM64Disable cache tests on ARM64Skip non-Firefox config tests on ARM64Skip non-Firefox driver tests on ARM64Use Firefox for ARM64 mirror testsUse Firefox for ARM64 offline testsUse Firefox for ARM64 output testsUse Firefox for ARM64 proxy testsSkip non-Firefox stable tests on ARM64Disable webview tests on ARM641 files
Add ARM64 detection helper function1 files
Add Ubuntu ARM64 runner to CI