Skip to content

[js]: skip fedcm tests until Chrome 140 #16137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 6, 2025
Merged

[js]: skip fedcm tests until Chrome 140 #16137

merged 2 commits into from
Aug 6, 2025

Conversation

@navin772
Copy link
Member

@navin772 navin772 commented Aug 6, 2025 •
edited by qodo-merge-pro bot
Loading

User description

🔗 Related Issues

💥 What does this PR do?

Skips fedcm tests for JS - https://issues.chromium.org/u/0/issues/425801332

🔧 Implementation Notes

💡 Additional Considerations

🔄 Types of changes

  • Cleanup (formatting, renaming)

PR Type

Other

Description

  • Skip FedCM tests in JavaScript until Chrome 140

  • Add comment referencing Chromium issue #425801332

Diagram Walkthrough

flowchart LR
  A["FedCM Tests"] -- "skip until" --> B["Chrome 140 Release"]
  C["Chromium Issue"] -- "blocks" --> A
Loading

File Walkthrough
Relevant files
Tests
fedcm_test.js
Skip FedCM test suite temporarily                                               

javascript/selenium-webdriver/test/fedcm/fedcm_test.js

  • Changed describe to describe.skip to disable test suite
  • Added comment explaining the skip reason with Chromium issue link
 +2/-1     

@selenium-ci selenium-ci added C-nodejs JavaScript Bindings and removed Review effort 1/5 labels Aug 6, 2025
@qodo-merge-pro
Copy link
Contributor

qodo-merge-pro bot commented Aug 6, 2025

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ❌

1234 - Not compliant

Non-compliant requirements:

• Fix JavaScript execution in link href on click() for Firefox
• Ensure compatibility with Firefox 42.0
• Restore functionality that worked in version 2.47.1 but broke in 2.48.0/2.48.2

5678 - Not compliant

Non-compliant requirements:

• Fix ChromeDriver ConnectFailure error on Ubuntu 16.04.4
• Resolve connection refused errors for subsequent ChromeDriver instances
• Ensure proper ChromeDriver instantiation beyond the first instance

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Unrelated Change

This PR skips FedCM tests due to a Chromium issue but doesn't address the actual ticket requirements about Firefox JavaScript execution or ChromeDriver connection issues. The change appears unrelated to the referenced tickets.

 
// Failing due to - https://issues.chromium.org/u/0/issues/425801332, enable when Chrome 140 is released
describe.skip('Federated Credential Management Test', function () {

@qodo-merge-pro
Copy link
Contributor

qodo-merge-pro bot commented Aug 6, 2025 •
edited
Loading

PR Code Suggestions ✨

No code suggestions found for the PR.

@navin772 navin772 merged commit 7a35455 into SeleniumHQ:trunk Aug 6, 2025
12 of 15 checks passed
@navin772 navin772 deleted the skip-fedcm-js branch August 6, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

C-nodejs JavaScript Bindings

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@navin772 @selenium-ci