Skip to content

[py] Fix type annotation error and raise clearer error message #16174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 20, 2025
Merged

[py] Fix type annotation error and raise clearer error message #16174

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4b60710
Fix type annotation errors in virtual_authenticator.py and errorhandl…
Paresh-0007 Aug 13, 2025
f404acf
Merge branch 'SeleniumHQ:trunk' into fix-python-type-annotations
Paresh-0007 Aug 18, 2025
fbe7d2a
[py] Implemented the feedback: simplify rpId handling and message ext…
Paresh-0007 Aug 18, 2025
4722123
Merge branch 'fix-python-type-annotations' of https://github.com/Pare…
Paresh-0007 Aug 18, 2025
c4b770e
Merge branch 'trunk' into fix-python-type-annotations
Paresh-0007 Aug 19, 2025
cafdc25
[py] Apply ruff formatting cause check pass was failing
Paresh-0007 Aug 19, 2025
6845c21
Merge branch 'fix-python-type-annotations' of https://github.com/Pare…
Paresh-0007 Aug 19, 2025
464cc9f
[py] Incorporated the changes
Paresh-0007 Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion py/selenium/webdriver/common/virtual_authenticator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,9 @@ def to_dict(self) -> dict[str, Any]:
def from_dict(cls, data: dict[str, Any]) -> "Credential":
_id = urlsafe_b64decode(f"{data['credentialId']}==")
is_resident_credential = bool(data["isResidentCredential"])
rp_id = data.get("rpId", None)
if "rpId" not in data:
raise KeyError("Missing required field 'rpId' in credential data.")
rp_id = data["rpId"]
private_key = urlsafe_b64decode(f"{data['privateKey']}==")
sign_count = int(data["signCount"])
user_handle = urlsafe_b64decode(f"{data['userHandle']}==") if data.get("userHandle", None) else None
Expand Down
9 changes: 7 additions & 2 deletions py/selenium/webdriver/remote/errorhandler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,10 @@ def check_response(self, response: dict[str, Any]) -> None:
message = value.get("value") or value.get("message")
if not isinstance(message, str):
value = message
message = message.get("message")
if isinstance(message, dict):
message = message.get("message")
else:
message = None
else:
message = value.get("message", None)
except ValueError:
Expand Down Expand Up @@ -202,7 +205,9 @@ def check_response(self, response: dict[str, Any]) -> None:
screen = value["screen"]

stacktrace = None
st_value = value.get("stackTrace") or value.get("stacktrace")
st_value = None
if isinstance(value, dict):
st_value = value.get("stackTrace") or value.get("stacktrace")
if st_value:
if isinstance(st_value, str):
stacktrace = st_value.split("\n")
Expand Down