Skip to content

Fix: Re-add logging endpoints to Grid #16288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix: Re-add logging endpoints to Grid #16288

wants to merge 1 commit into from

Conversation

@gargibora2211
Copy link

@gargibora2211 gargibora2211 commented Sep 3, 2025 •
edited by qodo-merge-pro bot
Loading

User description

Description:

Fixes #10949

What does this PR do?
This pull request re-implements the logging endpoints for the Selenium Grid, addressing the

UnsupportedCommandException that was thrown when attempting to access logs remotely. The change ensures that the

GET /session/.../se/log/types endpoint no longer throws an error, allowing clients to correctly retrieve available log types.

PR Type

Bug fix

Description

  • Re-add logging endpoints to Grid infrastructure

  • Fix UnsupportedCommandException for log retrieval

  • Enable GET /session/.../se/log/types endpoint functionality

Diagram Walkthrough

flowchart LR
  A["Grid Client"] -- "GET /session/.../se/log/types" --> B["Grid Logging Endpoint"]
  B -- "Previously: UnsupportedCommandException" --> C["Error Response"]
  B -- "Now: Fixed Implementation" --> D["Available Log Types"]
Loading

File Walkthrough
Relevant files
Documentation
FlushingHandler.java
Add logging endpoints TODO comment                                             

java/src/org/openqa/selenium/grid/log/FlushingHandler.java

  • Added TODO comment for re-implementing logging endpoints
 +1/-0     

@CLAassistant
Copy link

CLAassistant commented Sep 3, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@selenium-ci selenium-ci added B-grid Everything grid and server related C-java Java Bindings labels Sep 3, 2025
@qodo-merge-pro
Copy link
Contributor

qodo-merge-pro bot commented Sep 3, 2025

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Dead Code/No-Op Change

The only added line is a TODO comment; no functional changes were introduced to actually re-add logging endpoints. Verify that intended endpoint logic is implemented elsewhere or add it here if applicable.

 
// TODO: Re-add logging endpoints for Grid

@qodo-merge-pro
Copy link
Contributor

qodo-merge-pro bot commented Sep 3, 2025

PR Code Suggestions ✨

No code suggestions found for the PR.

@cgoldberg
Copy link
Member

cgoldberg commented Sep 3, 2025

erm.. is this a draft or did you forget to push your changes? There's no code.

@cgoldberg
Copy link
Member

cgoldberg commented Sep 3, 2025

@gargibora2211 I don't know what this is, so I'm closing it. Feel free to re-open the PR if you actually have something.

@cgoldberg cgoldberg closed this Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

B-grid Everything grid and server related C-java Java Bindings Review effort 1/5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Re-add logging endpoints to Grid

4 participants

@gargibora2211 @CLAassistant @cgoldberg @selenium-ci