-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[rb] mark low level bidi implementation as private api #16475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
||||||||||||
User description
We all know anyone can do whatever they want with Ruby objects, but the source code should indicate which things we should be trying to use.
PR Type
Documentation
Description
Mark low-level BiDi implementation classes as private API
Add
@api privateYARD documentation tags to internal modulesClarify recommended public API alternatives in class documentation
Improve code documentation with module descriptions
Diagram Walkthrough
File Walkthrough
13 files
Add private API documentation to Browser classAdd private API tag and usage guidance to BrowsingContextAdd private API documentation to LogHandler classAdd private API documentation to Network classAdd private API tag to Cookies classAdd private API tag to Credentials classAdd private API tag to Headers classAdd private API tag to InterceptedAuth classAdd private API tag to InterceptedItem classAdd private API tag to InterceptedRequest classAdd private API tag to InterceptedResponse classAdd private API tag to UrlPattern moduleAdd private API documentation to Session class