fix virtual authenticator

Author: titusfortner

examples/ruby/spec/interactions/virtual_authenticator_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'selenium-webdriver'
+require 'spec_helper'
 
 RSpec.describe 'Virtual Authenticator' do
   let(:driver) { start_session }
@@ -41,32 +41,32 @@
 
   it 'creates virtual authenticator' do
     options = Selenium::WebDriver::VirtualAuthenticatorOptions.new(protocol: :u2f, resident_key: false)
-    @authenticator = driver.add_virtual_authenticator(options)
+    authenticator = driver.add_virtual_authenticator(options)
 
-    expect(@authenticator.valid?).to eq true
+    expect(authenticator.valid?).to eq true
   end
 
   it 'removes virtual authenticator' do
     options = Selenium::WebDriver::VirtualAuthenticatorOptions.new
-    @authenticator = driver.add_virtual_authenticator(options)
-    @authenticator.remove!
+    authenticator = driver.add_virtual_authenticator(options)
+    authenticator.remove!
 
-    expect(@authenticator.valid?).to eq false
+    expect(authenticator.valid?).to eq false
   end
 
   it 'creates and add resident credential' do
     options = Selenium::WebDriver::VirtualAuthenticatorOptions.new(protocol: :ctap2, resident_key: true,
                                                                    user_verification: true, user_verified: true)
-    @authenticator = driver.add_virtual_authenticator(options)
+    authenticator = driver.add_virtual_authenticator(options)
 
     resident_credential = Selenium::WebDriver::Credential.resident(id: [1, 2, 3, 4],
                                                                    rp_id: 'localhost',
                                                                    user_handle: [1],
                                                                    private_key: Selenium::WebDriver::Credential
                                                                                   .decode(encoded_private_key),
                                                                    sign_count: 0)
-    @authenticator.add_credential(resident_credential)
-    credential_list = @authenticator.credentials
+    authenticator.add_credential(resident_credential)
+    credential_list = authenticator.credentials
     expect(credential_list.length).to eq 1
 
     credential_id = credential_list.first.id
@@ -75,7 +75,7 @@
 
   it 'does not support resident credential when authenticator uses u2f protocol' do
     options = Selenium::WebDriver::VirtualAuthenticatorOptions.new(protocol: :u2f, resident_key: true)
-    @authenticator = driver.add_virtual_authenticator(options)
+    authenticator = driver.add_virtual_authenticator(options)
 
     resident_credential = Selenium::WebDriver::Credential.resident(id: [1, 2, 3, 4],
                                                                    rp_id: 'localhost',
@@ -85,21 +85,21 @@
                                                                    sign_count: 0)
 
     expect {
-      @authenticator.add_credential(resident_credential)
+      authenticator.add_credential(resident_credential)
     }.to raise_error(Selenium::WebDriver::Error::InvalidArgumentError)
   end
 
   it 'creates and add non-resident credential' do
     options = Selenium::WebDriver::VirtualAuthenticatorOptions.new(protocol: :u2f, resident_key: false)
-    @authenticator = driver.add_virtual_authenticator(options)
+    authenticator = driver.add_virtual_authenticator(options)
 
     non_resident_credential = Selenium::WebDriver::Credential.non_resident(id: [1, 2, 3, 4],
                                                                            rp_id: 'localhost',
                                                                            private_key: Selenium::WebDriver::Credential
                                                                                           .decode(pkcs8_private_key),
                                                                            sign_count: 0)
-    @authenticator.add_credential(non_resident_credential)
-    credentials = @authenticator.credentials
+    authenticator.add_credential(non_resident_credential)
+    credentials = authenticator.credentials
 
     expect(credentials.length).to eq 1
     expect(credentials.first.id).to eq [1, 2, 3, 4]
@@ -108,7 +108,7 @@
   it 'gets all credentials' do
     options = Selenium::WebDriver::VirtualAuthenticatorOptions.new(protocol: :ctap2, resident_key: true,
                                                                    user_verification: true, user_verified: true)
-    @authenticator = @driver.add_virtual_authenticator(options)
+    authenticator = driver.add_virtual_authenticator(options)
 
     resident_credential = Selenium::WebDriver::Credential.resident(id: [1, 2, 3, 4],
                                                                    rp_id: 'localhost',
@@ -121,27 +121,27 @@
                                                                            private_key: Selenium::WebDriver::Credential
                                                                                           .decode(encoded_private_key),
                                                                            sign_count: 0)
-    @authenticator.add_credential(resident_credential)
-    @authenticator.add_credential(non_resident_credential)
+    authenticator.add_credential(resident_credential)
+    authenticator.add_credential(non_resident_credential)
 
-    credentials = @authenticator.credentials
+    credentials = authenticator.credentials
     expect(credentials.length).to eq 2
     expect(credentials.first.id).to eq [1, 2, 3, 4]
   end
 
   it 'removes all credentials' do
     options = Selenium::WebDriver::VirtualAuthenticatorOptions.new
-    @authenticator = driver.add_virtual_authenticator(options)
+    authenticator = driver.add_virtual_authenticator(options)
 
     non_resident_credential = Selenium::WebDriver::Credential.non_resident(id: [1, 2, 3, 4],
                                                                            rp_id: 'localhost',
                                                                            private_key: Selenium::WebDriver::Credential
                                                                                           .decode(encoded_private_key),
                                                                            sign_count: 0)
-    @authenticator.add_credential(non_resident_credential)
-    expect(@authenticator.credentials.length).to eq 1
+    authenticator.add_credential(non_resident_credential)
+    expect(authenticator.credentials.length).to eq 1
 
-    @authenticator.remove_all_credentials
-    expect(@authenticator.credentials).to be_empty
+    authenticator.remove_all_credentials
+    expect(authenticator.credentials).to be_empty
   end
 end