Merge branch 'trunk' into petesong/add-practice-example

Author: PeteSong

.github/workflows/ruby-examples.yml

@@ -110,3 +110,20 @@ jobs:
           new_command_on_retry: |
             cd examples/ruby
             DEBUG=true bundle exec rspec --only-failures --backtrace
+
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout GitHub repo
+        uses: actions/checkout@v4
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 3.1
+          bundler-cache: true
+      - name: Install dependencies
+        working-directory: ./examples/ruby
+        run: bundle install
+      - name: Run RuboCop
+        working-directory: ./examples/ruby
+        run: bundle exec rubocop

examples/ruby/.rubocop.yml

@@ -1,9 +1,10 @@
 inherit_from: .rubocop_todo.yml
 
-require: rubocop-rspec
+plugins:
+  - rubocop-rspec
 
 AllCops:
-  TargetRubyVersion: 3.0
+  TargetRubyVersion: 3.1
   NewCops: enable
   SuggestExtensions:
     rubocop-rake: false

examples/ruby/Gemfile

@@ -7,5 +7,5 @@ gem 'rake', '~> 13.0'
 gem 'rspec', '~> 3.0'
 gem 'rubocop', '~> 1.35'
 gem 'rubocop-rspec', '~> 3.0'
-gem 'selenium-devtools', '= 0.134.0'
+gem 'selenium-devtools', '= 0.135.0'
 gem 'selenium-webdriver', '= 4.31.0'

examples/ruby/Gemfile.lock

@@ -48,7 +48,7 @@ GEM
       rubocop (~> 1.72, >= 1.72.1)
     ruby-progressbar (1.13.0)
     rubyzip (2.4.1)
-    selenium-devtools (0.134.0)
+    selenium-devtools (0.135.0)
       selenium-webdriver (~> 4.2)
     selenium-webdriver (4.31.0)
       base64 (~> 0.2)
@@ -64,6 +64,7 @@ PLATFORMS
   arm64-darwin-22
   arm64-darwin-23
   arm64-darwin-24
+  ruby
   x86_64-darwin-19
   x86_64-darwin-20
   x86_64-darwin-22
@@ -74,7 +75,7 @@ DEPENDENCIES
   rspec (~> 3.0)
   rubocop (~> 1.35)
   rubocop-rspec (~> 3.0)
-  selenium-devtools (= 0.134.0)
+  selenium-devtools (= 0.135.0)
   selenium-webdriver (= 4.31.0)
 
 BUNDLED WITH

examples/ruby/spec/browsers/firefox_spec.rb

@@ -89,7 +89,7 @@
   describe 'Features' do
     let(:driver) { start_firefox }
 
-    it 'installs addon', :skip => "Skipping tests until Firefox 127 is released" do
+    it 'installs addon' do
       extension_file_path = File.expand_path('../spec_support/extensions/webextensions-selenium-example.xpi', __dir__)
 
       driver.install_addon(extension_file_path)
@@ -99,7 +99,7 @@
       expect(injected.text).to eq 'Content injected by webextensions-selenium-example'
     end
 
-    it 'uninstalls addon', :skip => "Skipping tests until Firefox 127 is released" do
+    it 'uninstalls addon' do
       extension_file_path = File.expand_path('../spec_support/extensions/webextensions-selenium-example.xpi', __dir__)
       extension_id = driver.install_addon(extension_file_path)
 
@@ -109,7 +109,7 @@
       expect(driver.find_elements(id: 'webextensions-selenium-example')).to be_empty
     end
 
-    it 'installs unsigned addon', :skip => "Skipping tests until Firefox 127 is released" do
+    it 'installs unsigned addon' do
       extension_dir_path = File.expand_path('../spec_support/extensions/webextensions-selenium-example/', __dir__)
 
       driver.install_addon(extension_dir_path, true)

examples/ruby/spec/elements/finders_spec.rb

@@ -12,31 +12,31 @@
 
     it 'uses a subset of the dom to find an element' do
       fruits = driver.find_element(id: 'fruits')
-      fruit = fruits.find_element(class: 'tomatoes')
+      fruits.find_element(class: 'tomatoes')
     end
 
     it 'uses an optimized locator' do
-      fruit = driver.find_element(css: '#fruits .tomatoes')
+      driver.find_element(css: '#fruits .tomatoes')
     end
 
     it 'finds all matching elements' do
-      plants = driver.find_elements(tag_name: 'li')
+      driver.find_elements(tag_name: 'li')
     end
 
     it 'gets an element from a collection' do
-      elements = driver.find_elements(:tag_name,'p')
+      elements = driver.find_elements(:tag_name, 'p')
       elements.each { |e| puts e.text }
     end
 
     it 'finds element from element' do
-      element = driver.find_element(:tag_name,'div')
-      elements = element.find_elements(:tag_name,'p')
+      element = driver.find_element(:tag_name, 'div')
+      elements = element.find_elements(:tag_name, 'p')
       elements.each { |e| puts e.text }
     end
 
     it 'find active element' do
       driver.find_element(css: '[name="q"]').send_keys('webElement')
-      attr = driver.switch_to.active_element.attribute('title')
+      driver.switch_to.active_element.attribute('title')
     end
   end
 end

examples/ruby/spec/getting_started/using_selenium_spec.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
+
 require 'spec_helper'
 require 'selenium-webdriver'
 
-
 RSpec.describe 'Using Selenium' do
   before do
     @driver = Selenium::WebDriver.for :chrome

examples/ruby/spec/spec_helper.rb

@@ -10,14 +10,14 @@
   # Disable RSpec exposing methods globally on `Module` and `main`
   config.disable_monkey_patching!
   Dir.mktmpdir('tmp')
-  config.example_status_persistence_file_path = "tmp/examples.txt"
+  config.example_status_persistence_file_path = 'tmp/examples.txt'
 
   config.expect_with :rspec do |c|
     c.syntax = :expect
   end
 
   config.before do |example|
-    bug_tracker = 'https://gigithub.com/SeleniumHQ/seleniumhq.github.io/issues'
+    bug_tracker = 'https://github.com/SeleniumHQ/seleniumhq.github.io/issues'
     guards = Selenium::WebDriver::Support::Guards.new(example,
                                                       bug_tracker: bug_tracker)
     guards.add_condition(:platform, Selenium::WebDriver::Platform.os)

examples/ruby/spec/spec_support/extensions/webextensions-selenium-example.crx

@@ -14,9 +14,17 @@
       ]
     }
   ],
+  "permissions": [
+    "storage",
+    "scripting"
+  ],
+  "host_permissions": [
+    "https://*/*",
+    "http://*/*"
+  ],
   "browser_specific_settings": {
     "gecko": {
       "id": "[email protected]"
     }
   }
-}
+}