Skip to content

Conversation

@Delta456
Copy link
Member

@Delta456 Delta456 commented Nov 4, 2024

User description

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Adds Safari Technology Preview code for Python

Motivation and Context

They were missing so I had to add them. Below is a preview of how they look like.

image

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

documentation


Description

  • Added Python code examples for Safari Technology Preview across multiple language documentation files.
  • Replaced placeholder badge-code with actual code block reference in English, Japanese, Portuguese, and Chinese documentation.

Changes walkthrough 📝

Relevant files
Documentation
safari.en.md
Add Python code example for Safari Technology Preview       

website_and_docs/content/documentation/webdriver/browsers/safari.en.md

  • Added Python code example for Safari Technology Preview.
  • Replaced placeholder with actual code block reference.
  • +1/-1     
    safari.ja.md
    Add Python code example for Safari Technology Preview       

    website_and_docs/content/documentation/webdriver/browsers/safari.ja.md

  • Added Python code example for Safari Technology Preview.
  • Replaced placeholder with actual code block reference.
  • +1/-1     
    safari.pt-br.md
    Add Python code example for Safari Technology Preview       

    website_and_docs/content/documentation/webdriver/browsers/safari.pt-br.md

  • Added Python code example for Safari Technology Preview.
  • Replaced placeholder with actual code block reference.
  • +1/-1     
    safari.zh-cn.md
    Add Python code example for Safari Technology Preview       

    website_and_docs/content/documentation/webdriver/browsers/safari.zh-cn.md

  • Added Python code example for Safari Technology Preview.
  • Replaced placeholder with actual code block reference.
  • +1/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @netlify
    Copy link

    netlify bot commented Nov 4, 2024

    👷 Deploy request for selenium-dev pending review.

    Visit the deploys page to approve it

    Name Link
    🔨 Latest commit 6adf510

    @qodo-merge-pro
    Copy link
    Contributor

    qodo-merge-pro bot commented Nov 4, 2024

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    @qodo-merge-pro
    Copy link
    Contributor

    qodo-merge-pro bot commented Nov 4, 2024

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Copy link
    Member

    @harsha509 harsha509 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Thank you @Delta456 !

    @harsha509 harsha509 merged commit fa77979 into SeleniumHQ:trunk Nov 4, 2024
    3 checks passed
    @Delta456 Delta456 deleted the safari_technology_py branch November 4, 2024 15:55
    selenium-ci added a commit that referenced this pull request Nov 4, 2024
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants