You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for contributing to the Selenium site and documentation! A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
Description
Added docs for get_log for chrome and edge in python
Types of changes
Change to the site (I have double-checked the Netlify deployment, and my changes look good)
Code example added (and I also added the example to all translated languages)
Improved translation
Added new translation (and I also added a notice to each document missing translation)
Here are some key observations to aid the review process:
⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ Recommended focus areas for review
Test Reliability The test assumes there will be an 'Uncaught TypeError' in the logs when visiting selenium.dev. This assumption may be fragile and could lead to flaky tests if the site changes.
Test Reliability The test assumes there will be an 'Uncaught TypeError' in the logs when visiting selenium.dev. This assumption may be fragile and could lead to flaky tests if the site changes.
Resource Cleanup The driver.quit() call should be in a finally block to ensure cleanup even if the test fails
Ensure test reliability by explicitly generating the log message to be verified instead of relying on undefined behavior
The test assumes there will be an "Uncaught TypeError" in the logs without explicitly triggering one. This makes the test unreliable. Instead, execute JavaScript that will generate a known error to test log capture.
driver.get("https://www.selenium.dev/")
+driver.execute_script("console.error('Test Error Message')")
logs = driver.get_log("browser")
-assert any("Uncaught TypeError" in log['message'] for log in logs), "No matching log message found."+assert any("Test Error Message" in log['message'] for log in logs), "No matching log message found."
Apply this suggestion
Suggestion importance[1-10]: 9
Why: The suggestion significantly improves test reliability by explicitly generating the log message to verify instead of relying on random TypeError occurrences. This makes the test deterministic and prevents flaky behavior.
9
General
Ensure proper resource cleanup by using try-finally block for driver termination
Add cleanup in a try-finally block to ensure the driver is always quit, even if the test fails.
def test_get_browser_logs():
driver = webdriver.Chrome()
- driver.get("https://www.selenium.dev/")- logs = driver.get_log("browser")- assert any("Uncaught TypeError" in log['message'] for log in logs), "No matching log message found."- driver.quit()+ try:+ driver.get("https://www.selenium.dev/")+ logs = driver.get_log("browser")+ assert any("Uncaught TypeError" in log['message'] for log in logs), "No matching log message found."+ finally:+ driver.quit()
Apply this suggestion
Suggestion importance[1-10]: 8
Why: The suggestion ensures proper cleanup of browser resources by wrapping driver operations in a try-finally block, preventing resource leaks even if the test fails. This is a critical best practice for WebDriver test reliability.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
Description
Added docs for
get_logfor chrome and edge in pythonTypes of changes
Checklist
PR Type
Documentation, Tests
Description
get_logmethod.Changes walkthrough 📝
2 files
test_chrome.py
Add test for retrieving Chrome browser logsexamples/python/tests/browsers/test_chrome.py
test_edge.py
Add test for retrieving Edge browser logsexamples/python/tests/browsers/test_edge.py
8 files
chrome.en.md
Add Python example for Chrome `get_log` documentationwebsite_and_docs/content/documentation/webdriver/browsers/chrome.en.md
get_login Chrome documentation.chrome.ja.md
Add Python example for Chrome `get_log` documentationwebsite_and_docs/content/documentation/webdriver/browsers/chrome.ja.md
get_login Chrome documentation.chrome.pt-br.md
Add Python example for Chrome `get_log` documentationwebsite_and_docs/content/documentation/webdriver/browsers/chrome.pt-br.md
get_login Chrome documentation.chrome.zh-cn.md
Add Python example for Chrome `get_log` documentationwebsite_and_docs/content/documentation/webdriver/browsers/chrome.zh-cn.md
get_login Chrome documentation.edge.en.md
Add Python example for Edge `get_log` documentationwebsite_and_docs/content/documentation/webdriver/browsers/edge.en.md
get_login Edge documentation.edge.ja.md
Add Python example for Edge `get_log` documentationwebsite_and_docs/content/documentation/webdriver/browsers/edge.ja.md
get_login Edge documentation.edge.pt-br.md
Add Python example for Edge `get_log` documentationwebsite_and_docs/content/documentation/webdriver/browsers/edge.pt-br.md
get_login Edge documentation.edge.zh-cn.md
Add Python example for Edge `get_log` documentationwebsite_and_docs/content/documentation/webdriver/browsers/edge.zh-cn.md
get_login Edge documentation.