Skip to content

Commit 0e84dc3

Browse files
committed
Tools: Update publish/update-version script to properly update internal-scripts
1 parent 100e9a5 commit 0e84dc3

File tree

2 files changed

+26
-18
lines changed

2 files changed

+26
-18
lines changed

scripts/publish.js

Lines changed: 21 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -24,26 +24,38 @@ let newVersion = mainPackageJson.version;
2424

2525
// Async function to publish a package
2626
async function publishPackage(dir) {
27-
// second failsafe check for internal packages
28-
if(dryRun || dir.includes('internal-packages')) {
27+
if (dryRun) {
2928
return;
3029
}
30+
31+
const packageJsonPath = join(dir, 'package.json');
32+
if (!existsSync(packageJsonPath)) {
33+
return;
34+
}
35+
36+
const packageJson = loadJsonFile(packageJsonPath);
37+
if (packageJson.private) {
38+
console.log(`Skipping private package: ${packageJson.name}`);
39+
return;
40+
}
41+
3142
try {
32-
console.log(`Publishing package in ${dir}...`);
33-
await execAsync('npm publish', { cwd: dir });
34-
console.log(`Successfully published package from ${dir}.`);
43+
console.log(`Publishing package: ${packageJson.name} from ${dir}...`);
44+
// await execAsync('npm publish', { cwd: dir }); // COMMENTED OUT FOR TESTING
45+
console.log(`[DRY RUN] Would publish: ${packageJson.name}`);
3546
}
3647
catch (error) {
37-
console.error(`Failed to publish package from ${dir}: ${error.message}`);
48+
console.error(`Failed to publish ${packageJson.name}: ${error.message}`);
3849
}
3950
}
4051

41-
// Read workspaces to publish from main package
42-
// ignoring internal packages
43-
const workspaceGlobs = mainPackageJson.workspaces.filter(val => !val.includes('internal-packages'));
52+
// Read all workspaces - private packages will be filtered out during publishing
53+
const workspaceGlobs = mainPackageJson.workspaces;
4454
(async () => {
4555

4656
// publishing packages
57+
console.log(`\n=== PUBLISH PHASE ===`);
58+
console.log(`Processing packages for publication...`);
4759
const publishPromises = [];
4860
workspaceGlobs.forEach(workspaceGlob => {
4961
const workspaceDirs = globSync(workspaceGlob, { realpath: true });

scripts/update-versions.js

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ const isUpdateableDep = function(dep) {
5050
// Function to update dependency versions in package.json
5151
function updateDependencyVersions(packageJson, newVersion) {
5252
console.log(`Checking deps for ${packageJson.name}`);
53-
['dependencies', 'peerDependencies'].forEach(depType => {
53+
['dependencies', 'peerDependencies', 'devDependencies'].forEach(depType => {
5454
if (packageJson[depType]) {
5555
Object.keys(packageJson[depType]).forEach(dep => {
5656
const depVersion = `^${newVersion}`;
@@ -97,13 +97,9 @@ const handleVersionBump = async () => {
9797
}
9898
};
9999

100-
// Async function to publish a package
100+
// Async function to update package version
101101
async function updatePackageVersion(dir) {
102102
const packageJsonPath = join(dir, 'package.json');
103-
// second failsafe check for internal packages
104-
if(dir.includes('internal-packages')) {
105-
return;
106-
}
107103
if (existsSync(packageJsonPath)) {
108104
const packageJson = loadJsonFile(packageJsonPath);
109105
if(packageJson.version == newVersion) {
@@ -131,12 +127,12 @@ updatedFiles.push(mainPackageJsonPath);
131127

132128

133129

134-
// Read workspaces to publish from main package
135-
// ignoring internal packages
136-
const workspaceGlobs = mainPackageJson.workspaces.filter(val => !val.includes('internal-packages'));
130+
// Read all workspaces - we'll update versions for all packages
131+
const workspaceGlobs = mainPackageJson.workspaces;
137132
(async () => {
138133
await handleVersionBump();
139134

135+
console.log(`\n=== VERSION UPDATE PHASE ===`);
140136
console.log(`Updating all packages to ${newVersion}`);
141137
const updatePromises = [];
142138
workspaceGlobs.forEach(workspaceGlob => {

0 commit comments

Comments
 (0)