Bug/Feat: Fix issues with reinit calling on init. Add index args for groups

Author: jlukic

packages/query/src/behavior.js

@@ -53,6 +53,10 @@ export class Behavior {
     // custom invocation fallback
     customInvocation = noop,
 
+    // element index information
+    elementIndex = 0,
+    totalElements = 1,
+
     // standard
     selectors = {},
     classNames = {},
@@ -72,6 +76,10 @@ export class Behavior {
     this.namespace = namespace;
     this.customInvocation = customInvocation;
 
+    // store element index information
+    this.elementIndex = elementIndex;
+    this.totalElements = totalElements;
+
     this.classNames = classNames;
     this.selectors = selectors;
     this.errors = errors;
@@ -527,6 +535,13 @@ export class Behavior {
         self,
         behavior: self,
         namespace: self.namespace,
+
+        // element index information
+        index: self.elementIndex,
+        total: self.totalElements,
+        isFirst: self.elementIndex === 0,
+        isLast: self.elementIndex === self.totalElements - 1,
+
         get cache() {
           let cache = self.Query.prototype[self.namespace].cache;
           if (!cache) {

packages/query/src/register-behavior.js

@@ -1,4 +1,4 @@
-import { deepExtend, isArray, isDevelopment, isString, noop, pick } from '@semantic-ui/utils';
+import { deepExtend, filterObject, isArray, isDevelopment, isString, noop, pick } from '@semantic-ui/utils';
 import { Behavior } from './behavior.js';
 import { Query } from './query.js';
 
@@ -80,7 +80,11 @@ export const registerBehavior = (behavior) => {
 
   // Create abstraction around behavior initialization
   Query.prototype[name] = function(settings) {
-    // At run time we need to check if defaults are changed from original registration
+    // ignore undefined settings
+    settings = filterObject(settings, (value) => value !== undefined);
+
+    // At run time we need to check if defaults are changed by user
+    // this can occur if $.plugin.defaultSettings is modified
     const defaultValues = ['defaultSettings', 'classNames', 'errors', 'selector'];
     const behaviorDefaults = pick(Query.prototype[name], ...defaultValues);
     const runtimeConfig = {
@@ -115,13 +119,17 @@ export const registerBehavior = (behavior) => {
 
       // behavior is stored in namespace like el.behavior
       let instance = Behavior.getInstance(element, namespace);
+      let existingInstance = !!instance;
 
       const behaviorConfig = {
         sharedBehavior, // setup can pass shared behavior across instances
         $element,
         Query,
         ...runtimeConfig,
         settings: runtimeSettings,
+        // pass element index information
+        elementIndex: index,
+        totalElements: $elements.length,
       };
 
       // create behavior instance if not defined
@@ -149,7 +157,7 @@ export const registerBehavior = (behavior) => {
           returnedValue = response;
         }
       }
-      else if (instance !== undefined) {
+      else if (existingInstance) {
         // if they are not calling a method and there are settings
         // than they are attempting to reinitialize the behavior with new settings
         instance.reinitialize(behaviorConfig);