pagination

Author: Sasha Kondrashov

src/addons/Pagination/Pagination.d.ts

@@ -45,9 +45,14 @@ export interface StrictPaginationProps {
    * Called on change of an active page.
    *
    * @param {SyntheticEvent} event - React's original SyntheticEvent.
-   * @param {object} data - All props.
+   * @param {object} props - All props.
+   * @param {number} activePage - Index of the newly active page.
    */
-  onPageChange?: (event: React.MouseEvent<HTMLAnchorElement>, data: PaginationProps) => void
+  onPageChange?: (
+    event: React.MouseEvent<HTMLAnchorElement>,
+    props: PaginationProps,
+    activePage: number,
+  ) => void
 
   /** Number of always visible pages before and after the current one. */
   siblingRange?: number | string

src/addons/Pagination/Pagination.js

@@ -55,7 +55,7 @@ const Pagination = React.forwardRef(function (props, ref) {
     }
 
     setActivePage(nextActivePage)
-    _.invoke(props, 'onPageChange', e, { ...props, activePage: nextActivePage })
+    _.invoke(props, 'onPageChange', e, props, nextActivePage)
   }
 
   const handleItemOverrides = (active, type, value) => (predefinedProps) => ({

test/specs/addons/Pagination/Pagination-test.js

@@ -24,7 +24,7 @@ describe('Pagination', () => {
   })
 
   describe('onPageChange', () => {
-    it('is called with (e, data) when clicked on a pagination item', () => {
+    it('is called when clicked a pagination item is clicked', () => {
       const onPageChange = sandbox.spy()
       const onPageItemClick = sandbox.spy()
 
@@ -40,7 +40,7 @@ describe('Pagination', () => {
       wrapper.find('PaginationItem').at(4).simulate('click')
 
       onPageChange.should.have.been.calledOnce()
-      onPageChange.should.have.been.calledWithMatch({ type: 'click' }, { activePage: 3 })
+      onPageChange.should.have.been.calledWithMatch({ type: 'click' }, {}, 3)
       onPageItemClick.should.have.been.calledOnce()
       onPageItemClick.should.have.been.calledWithMatch({ type: 'click' }, { value: 3 })
     })