rating

Author: Sasha Kondrashov

src/modules/Rating/Rating.d.ts

@@ -36,9 +36,10 @@ export interface StrictRatingProps {
    * Called after user selects a new rating.
    *
    * @param {SyntheticEvent} event - React's original SyntheticEvent.
-   * @param {object} data - All props and proposed rating.
+   * @param {object} props - All props.
+   * @param {number} props - New rating.
    */
-  onRate?: (event: React.MouseEvent<HTMLDivElement>, data: RatingProps) => void
+  onRate?: (event: React.MouseEvent<HTMLDivElement>, props: RatingProps, rating: number) => void
 
   /** The current number of active icons. */
   rating?: number | string

src/modules/Rating/Rating.js

@@ -58,7 +58,7 @@ const Rating = React.forwardRef(function (props, ref) {
     setRating(newRating)
     setIsSelecting(false)
 
-    _.invoke(props, 'onRate', e, { ...props, rating: newRating })
+    _.invoke(props, 'onRate', e, props, newRating)
   }
 
   const handleIconMouseEnter = (e, { index }) => {

test/specs/modules/Rating/Rating-test.js

@@ -241,16 +241,16 @@ describe('Rating', () => {
 
   describe('onRate', () => {
     it('is called with (event, { rating, maxRating } on icon click', () => {
-      const spy = sandbox.spy()
+      const onRate = sandbox.spy()
       const event = { fake: 'event data' }
 
-      mount(<Rating maxRating={3} onRate={spy} />)
+      mount(<Rating maxRating={3} onRate={onRate} />)
         .find('RatingIcon')
         .last()
         .simulate('click', event)
 
-      spy.should.have.been.calledOnce()
-      spy.should.have.been.calledWithMatch(event, { rating: 3, maxRating: 3 })
+      onRate.should.have.been.calledOnce()
+      onRate.should.have.been.calledWithMatch(event, { maxRating: 3 }, 3)
     })
   })