Address code review feedback: add default cases, fix docs, consolidate constants

Co-authored-by: dorkmo <[email protected]>

Author: Copilot

TankAlarm-112025-Client-BluesOpta/README.md

@@ -258,6 +258,7 @@ Hall effect sensors can be used to measure RPM (rotations per minute) for applic
 - `pulsesPerRevolution`: Number of pulses generated per complete rotation (default: 1)
   - Single magnet: 1 pulse per revolution
   - Multiple magnets: Set to number of magnets
+  - **Note:** For **bipolar** or **omnipolar** sensors, a single magnet generates 2 pulses per revolution (one for each pole). Set `pulsesPerRevolution` to `2 × number of magnets` in these cases.
 - `hallEffectType`: Sensor type - "unipolar", "bipolar", "omnipolar", or "analog"
 - `hallEffectDetection`: Detection method - "pulse" or "time"
 - `highAlarm`: Maximum expected RPM for alarm (e.g., 3000)
@@ -286,7 +287,7 @@ Hall effect sensors can be used to measure RPM (rotations per minute) for applic
 - Use "time" detection for faster response to speed changes
 - Use "pulse" detection for better accuracy at steady speeds
 - For multiple magnets, set `pulsesPerRev` to the number of magnets
-- For omnipolar sensors, each magnet passing creates a pulse (N and S poles both trigger)
+- For omnipolar sensors, each magnet passing creates 2 pulses (both N and S poles trigger)
 - Monitor both high and low thresholds to detect over-speed and stall conditions
 
 ## Operation

TankAlarm-112025-Client-BluesOpta/TankAlarm-112025-Client-BluesOpta.ino

@@ -873,13 +873,17 @@ static bool loadConfigFromFlash(ClientConfig &cfg) {
       cfg.tanks[i].hallEffectType = HALL_EFFECT_OMNIPOLAR;
     } else if (hallType && strcmp(hallType, "analog") == 0) {
       cfg.tanks[i].hallEffectType = HALL_EFFECT_ANALOG;
+    } else if (hallType && strcmp(hallType, "unipolar") == 0) {
+      cfg.tanks[i].hallEffectType = HALL_EFFECT_UNIPOLAR;
     } else {
       cfg.tanks[i].hallEffectType = HALL_EFFECT_UNIPOLAR; // Default
     }
     // Load hall effect detection method
     const char *hallDetect = t["hallEffectDetection"].as<const char *>();
     if (hallDetect && strcmp(hallDetect, "time") == 0) {
       cfg.tanks[i].hallEffectDetection = HALL_DETECT_TIME_BASED;
+    } else if (hallDetect && strcmp(hallDetect, "pulse") == 0) {
+      cfg.tanks[i].hallEffectDetection = HALL_DETECT_PULSE;
     } else {
       cfg.tanks[i].hallEffectDetection = HALL_DETECT_PULSE; // Default
     }
@@ -1894,6 +1898,10 @@ static float readTankSensor(uint8_t idx) {
       uint8_t pulsesPerRev = (cfg.pulsesPerRevolution > 0) ? cfg.pulsesPerRevolution : 1;
       const float MS_PER_MINUTE = 60000.0f;
 
+      // Common constants for both detection methods
+      const unsigned long DEBOUNCE_MS = 2;
+      const uint32_t MAX_ITERATIONS = RPM_SAMPLE_DURATION_MS * 2;
+      
       float rpm = 0.0f;
 
       // Choose detection method: pulse counting or time-based
@@ -1905,9 +1913,6 @@ static float readTankSensor(uint8_t idx) {
         unsigned long sampleStart = millis();
         int lastState = digitalRead(pin);
         gRpmLastPinState[idx] = lastState;
-        
-        const unsigned long DEBOUNCE_MS = 2;
-        const uint32_t MAX_ITERATIONS = RPM_SAMPLE_DURATION_MS * 2;
         unsigned long firstPulseTime = 0;
         unsigned long secondPulseTime = 0;
         unsigned long cycleLastPulseTime = 0; // Track last pulse within this measurement cycle for debounce
@@ -1932,6 +1937,10 @@ static float readTankSensor(uint8_t idx) {
               // Bipolar/Latching and Omnipolar: detect both edges (state changes)
               edgeDetected = (lastState != currentState);
               break;
+            default:
+              // Default to unipolar behavior if value is invalid/corrupted
+              edgeDetected = (lastState == HIGH && currentState == LOW);
+              break;
           }
 
           if (edgeDetected) {
@@ -1997,8 +2006,6 @@ static float readTankSensor(uint8_t idx) {
         int lastState = digitalRead(pin);
         gRpmLastPinState[idx] = lastState;
 
-        const unsigned long DEBOUNCE_MS = 2;
-        const uint32_t MAX_ITERATIONS = RPM_SAMPLE_DURATION_MS * 2;
         unsigned long lastPulseTime = 0;
         uint32_t iterationCount = 0;
 
@@ -2018,6 +2025,10 @@ static float readTankSensor(uint8_t idx) {
               // Bipolar/Latching and Omnipolar: count both edges (state changes)
               edgeDetected = (lastState != currentState);
               break;
+            default:
+              // Default to unipolar behavior for safety and consistency
+              edgeDetected = (lastState == HIGH && currentState == LOW);
+              break;
           }
 
           if (edgeDetected) {