Add validation for pulsesPerRevolution in config update

Copilot · dorkmo · Copilot · commit 9cb3877f6978 · 2025-11-28T18:45:54.000Z
Co-authored-by: dorkmo &lt;1923070+dorkmo@users.noreply.github.com&gt;
diff --git a/TankAlarm-112025-Client-BluesOpta/TankAlarm-112025-Client-BluesOpta.ino b/TankAlarm-112025-Client-BluesOpta/TankAlarm-112025-Client-BluesOpta.ino
@@ -989,7 +989,7 @@ static void applyConfigUpdate(const JsonDocument &doc) {
       gConfig.tanks[i].currentLoopChannel = t["loopChannel"].is<int>() ? t["loopChannel"].as<int>() : gConfig.tanks[i].currentLoopChannel;
       gConfig.tanks[i].rpmPin = t["rpmPin"].is<int>() ? t["rpmPin"].as<int>() : gConfig.tanks[i].rpmPin;
       if (t.containsKey("pulsesPerRev")) {
-        gConfig.tanks[i].pulsesPerRevolution = t["pulsesPerRev"].as<uint8_t>();
+        gConfig.tanks[i].pulsesPerRevolution = max((uint8_t)1, t["pulsesPerRev"].as<uint8_t>());
       }
       // Support both old field name (heightInches) and new (maxValue)
       if (t.containsKey("maxValue")) {

Original file line number	Diff line number	Diff line change
`@@ -989,7 +989,7 @@ static void applyConfigUpdate(const JsonDocument &doc) {`
`989`	`989`	`gConfig.tanks[i].currentLoopChannel = t["loopChannel"].is<int>() ? t["loopChannel"].as<int>() : gConfig.tanks[i].currentLoopChannel;`
`990`	`990`	`gConfig.tanks[i].rpmPin = t["rpmPin"].is<int>() ? t["rpmPin"].as<int>() : gConfig.tanks[i].rpmPin;`
`991`	`991`	`if (t.containsKey("pulsesPerRev")) {`
`992`		`- gConfig.tanks[i].pulsesPerRevolution = t["pulsesPerRev"].as<uint8_t>();`
	`992`	`+ gConfig.tanks[i].pulsesPerRevolution = max((uint8_t)1, t["pulsesPerRev"].as<uint8_t>());`
`993`	`993`	`}`
`994`	`994`	`// Support both old field name (heightInches) and new (maxValue)`
`995`	`995`	`if (t.containsKey("maxValue")) {`