Fix all four compilation errors in Arduino sketches

Co-authored-by: dorkmo <[email protected]>

Author: Copilot

TankAlarm-112025-Client-BluesOpta/TankAlarm-112025-Client-BluesOpta.ino

@@ -276,28 +276,6 @@ static float getDistanceConversionFactor(const char* unit) {
   return 1.0f; // Default: assume inches
 }
 
-// Helper function: Get tank height/capacity based on sensor configuration
-static float getMonitorHeight(const MonitorConfig &cfg) {
-  if (cfg.sensorInterface == SENSOR_CURRENT_LOOP) {
-    if (cfg.currentLoopType == CURRENT_LOOP_ULTRASONIC) {
-      // For ultrasonic sensors, mount height IS the tank height (distance to bottom)
-      return cfg.sensorMountHeight;
-    } else {
-      // For pressure sensors, max range + mount height approximates full tank height
-      float rangeInches = cfg.sensorRangeMax * getPressureConversionFactor(cfg.sensorRangeUnit);
-      return rangeInches + cfg.sensorMountHeight;
-    }
-  } else if (cfg.sensorInterface == SENSOR_ANALOG) {
-    // For analog sensors, max range + mount height approximates full tank height
-    float rangeInches = cfg.sensorRangeMax * getPressureConversionFactor(cfg.sensorRangeUnit);
-    return rangeInches + cfg.sensorMountHeight;
-  } else if (cfg.sensorInterface == SENSOR_DIGITAL) {
-    // Digital sensors are binary, treat 1.0 as full
-    return 1.0f;
-  }
-  return 0.0f;
-}
-
 static const uint8_t NOTECARD_I2C_ADDRESS = 0x17;
 static const uint32_t NOTECARD_I2C_FREQUENCY = 400000UL;
 
@@ -450,6 +428,28 @@ struct MonitorRuntime {
   unsigned long lastSensorFaultMillis;
 };
 
+// Helper function: Get tank height/capacity based on sensor configuration
+static float getMonitorHeight(const MonitorConfig &cfg) {
+  if (cfg.sensorInterface == SENSOR_CURRENT_LOOP) {
+    if (cfg.currentLoopType == CURRENT_LOOP_ULTRASONIC) {
+      // For ultrasonic sensors, mount height IS the tank height (distance to bottom)
+      return cfg.sensorMountHeight;
+    } else {
+      // For pressure sensors, max range + mount height approximates full tank height
+      float rangeInches = cfg.sensorRangeMax * getPressureConversionFactor(cfg.sensorRangeUnit);
+      return rangeInches + cfg.sensorMountHeight;
+    }
+  } else if (cfg.sensorInterface == SENSOR_ANALOG) {
+    // For analog sensors, max range + mount height approximates full tank height
+    float rangeInches = cfg.sensorRangeMax * getPressureConversionFactor(cfg.sensorRangeUnit);
+    return rangeInches + cfg.sensorMountHeight;
+  } else if (cfg.sensorInterface == SENSOR_DIGITAL) {
+    // Digital sensors are binary, treat 1.0 as full
+    return 1.0f;
+  }
+  return 0.0f;
+}
+
 static ClientConfig gConfig;
 static MonitorRuntime gMonitorState[MAX_TANKS];
 

TankAlarm-112025-Server-BluesOpta/TankAlarm-112025-Server-BluesOpta.ino

@@ -29,6 +29,7 @@
 #else
   #include <Ethernet.h>
 #endif
+#include <SD.h>
 #include <math.h>
 #include <string.h>
 #include <ctype.h>
@@ -3199,7 +3200,7 @@ static void handleFtpRestorePost(EthernetClient &client, const String &body) {
   if (ok) {
     resp["message"] = F("Restore completed from FTP");
   } else {
-    resp["error"] = error.length() ? error : F("Restore failed");
+    resp["error"] = strlen(error) ? error : F("Restore failed");
   }
   String json;
   serializeJson(resp, json);

TankAlarm-112025-Viewer-BluesOpta/TankAlarm-112025-Viewer-BluesOpta.ino

@@ -527,7 +527,7 @@ static void sendDashboard(EthernetClient &client) {
 static void sendTankJson(EthernetClient &client) {
   std::unique_ptr<DynamicJsonDocument> docPtr(new DynamicJsonDocument(TANK_JSON_CAPACITY + 256));
   if (!docPtr) {
-    respondStatus(client, 500, F("Out of Memory"));
+    respondStatus(client, 500, "Out of Memory");
     return;
   }
   DynamicJsonDocument &doc = *docPtr;