Update TankAlarm-112025-Client-BluesOpta/TankAlarm-112025-Client-BluesOpta.ino

dorkmo · Copilot · web-flow · commit aa6655dc6dc3 · 2025-11-28T09:28:49.000-06:00
Co-authored-by: Copilot &lt;175728472+Copilot@users.noreply.github.com&gt;
diff --git a/TankAlarm-112025-Client-BluesOpta/TankAlarm-112025-Client-BluesOpta.ino b/TankAlarm-112025-Client-BluesOpta/TankAlarm-112025-Client-BluesOpta.ino
@@ -1234,7 +1234,8 @@ static float readTankSensor(uint8_t idx) {
       }
       
       // Count pulses over the sampling duration
-      while (millis() - sampleStart < RPM_SAMPLE_DURATION_MS) {
+      // Use unsigned subtraction to handle millis() overflow correctly
+      while ((millis() - sampleStart) < (unsigned long)RPM_SAMPLE_DURATION_MS) {
         int currentState = digitalRead(pin);
         // Count falling edges (HIGH to LOW transitions)
         if (lastState == HIGH && currentState == LOW) {

Original file line number	Diff line number	Diff line change
`@@ -1234,7 +1234,8 @@ static float readTankSensor(uint8_t idx) {`
`1234`	`1234`	`}`
`1235`	`1235`
`1236`	`1236`	`// Count pulses over the sampling duration`
`1237`		`- while (millis() - sampleStart < RPM_SAMPLE_DURATION_MS) {`
	`1237`	`+ // Use unsigned subtraction to handle millis() overflow correctly`
	`1238`	`+ while ((millis() - sampleStart) < (unsigned long)RPM_SAMPLE_DURATION_MS) {`
`1238`	`1239`	`int currentState = digitalRead(pin);`
`1239`	`1240`	`// Count falling edges (HIGH to LOW transitions)`
`1240`	`1241`	`if (lastState == HIGH && currentState == LOW) {`