Fix coding styles and code analysis

Author: SenseException

phpstan.neon.dist

@@ -3,13 +3,6 @@ parameters:
     paths:
         - "%currentWorkingDirectory%/src/"
         - "%currentWorkingDirectory%/tests/"
-    ignoreErrors:
-        -
-            message: '#Call to an undefined method [a-zA-Z0-9\\_]+::children\(\)#'
-            path: %currentWorkingDirectory%/src/DependencyInjection/Configuration.php
-        -
-            message: '#Cannot call method [a-zA-Z]+\(\) on mixed#'
-            path: %currentWorkingDirectory%/src/DependencyInjection/Configuration.php
 includes:
     - vendor/phpstan/phpstan-strict-rules/rules.neon
     - phar://phpstan.phar/conf/bleedingEdge.neon

src/DependencyInjection/Configuration.php

@@ -7,14 +7,17 @@
 use ArrayIterator;
 use Budgegeria\Bundle\IntlBundle\DependencyInjection\CompilerPass\SorterBuilderKeyIterator;
 use Budgegeria\IntlSort\Builder;
+use Override;
 use ReflectionClass;
 use ReflectionMethod;
-use Symfony\Component\Config\Definition\Builder\NodeDefinition;
+use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
 use Symfony\Component\Config\Definition\Builder\TreeBuilder;
 use Symfony\Component\Config\Definition\ConfigurationInterface;
 
 class Configuration implements ConfigurationInterface
 {
+    /** @phpstan-return TreeBuilder<'array'> */
+    #[Override]
     public function getConfigTreeBuilder(): TreeBuilder
     {
         $treeBuilder = new TreeBuilder('budgegeria_intl');
@@ -26,7 +29,8 @@ public function getConfigTreeBuilder(): TreeBuilder
         return $treeBuilder;
     }
 
-    private function buildGeneric(NodeDefinition $node): void
+    /** @phpstan-param ArrayNodeDefinition<TreeBuilder<'array'>> $node */
+    private function buildGeneric(ArrayNodeDefinition $node): void
     {
         $node
             ->children()
@@ -35,7 +39,8 @@ private function buildGeneric(NodeDefinition $node): void
             ->end();
     }
 
-    private function buildSorter(NodeDefinition $node): void
+    /** @phpstan-param ArrayNodeDefinition<TreeBuilder<'array'>> $node */
+    private function buildSorter(ArrayNodeDefinition $node): void
     {
         $sorterChildren = $node->children()
             ->arrayNode('sorter')
@@ -44,7 +49,7 @@ private function buildSorter(NodeDefinition $node): void
 
         $methods = new ArrayIterator($this->getClassMethods(Builder::class));
         foreach (new SorterBuilderKeyIterator($methods) as $sorterConfigNames) {
-            $sorterChildren->scalarNode($sorterConfigNames)->end();
+            $sorterChildren->scalarNode((string) $sorterConfigNames)->end();
         }
 
         $sorterChildren->scalarNode('locale')->end();