Fix single reference is always visible for the system user even if it… (#2215)

kavics · web-flow · commit f2e58b61fcb4 · 2025-07-01T06:24:33.000Z
* Fix single reference is always visible for the system user even if it is not visible to the original user.

* Raise prerelease
diff --git a/src/ContentRepository.InMemory/SenseNet.ContentRepository.InMemory.csproj b/src/ContentRepository.InMemory/SenseNet.ContentRepository.InMemory.csproj
@@ -2,7 +2,7 @@
 
 	<PropertyGroup>
 		<TargetFramework>net8.0</TargetFramework>
-		<Version>1.1.2-alpha.5</Version>
+		<Version>1.1.2-alpha.6</Version>
 		<Authors>kavics,joe,tusmester</Authors>
 		<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
 		<Company>Sense/Net Inc.</Company>
diff --git a/src/ContentRepository.MsSql/SenseNet.ContentRepository.MsSql.csproj b/src/ContentRepository.MsSql/SenseNet.ContentRepository.MsSql.csproj
@@ -2,7 +2,7 @@
 
 	<PropertyGroup>
 		<TargetFramework>net8.0</TargetFramework>
-		<Version>1.1.2-alpha.5</Version>
+		<Version>1.1.2-alpha.6</Version>
 		<Authors>kavics,tusmester</Authors>
 		<Company>Sense/Net Inc.</Company>
 		<Copyright>Copyright © Sense/Net Inc.</Copyright>
diff --git a/src/ContentRepository/SenseNet.ContentRepository.csproj b/src/ContentRepository/SenseNet.ContentRepository.csproj
@@ -2,7 +2,7 @@
 
 	<PropertyGroup>
 		<TargetFramework>net8.0</TargetFramework>
-		<Version>7.8.2-alpha.5</Version>
+		<Version>7.8.2-alpha.6</Version>
 		<Authors>kavics,joe,tusmester,hashtagnulla</Authors>
 		<Company>Sense/Net Inc.</Company>
 		<Copyright>Copyright © Sense/Net Inc.</Copyright>
diff --git a/src/OData/SenseNet.OData.csproj b/src/OData/SenseNet.OData.csproj
@@ -2,7 +2,7 @@
 
 	<PropertyGroup>
 		<TargetFramework>net8.0</TargetFramework>
-		<Version>1.1.2-alpha.5</Version>
+		<Version>1.1.2-alpha.6</Version>
 		<Authors>kavics,tusmester,hashtagnulla</Authors>
 		<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
 		<Company>Sense/Net Inc.</Company>
diff --git a/src/OpenApi/SenseNet.OpenApi.csproj b/src/OpenApi/SenseNet.OpenApi.csproj
@@ -2,7 +2,7 @@
 
 	<PropertyGroup>
 		<TargetFramework>net8.0</TargetFramework>
-		<Version>1.1.2-alpha.5</Version>
+		<Version>1.1.2-alpha.6</Version>
 		<Authors>kavics,tusmester</Authors>
 		<Company>Sense/Net Inc.</Company>
 		<Copyright>Copyright © Sense/Net Inc.</Copyright>
diff --git a/src/Services.Core.Install/SenseNet.Services.Core.Install.csproj b/src/Services.Core.Install/SenseNet.Services.Core.Install.csproj
@@ -3,7 +3,7 @@
 	<PropertyGroup>
 		<TargetFramework>net8.0</TargetFramework>
 		<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
-		<Version>1.1.2-alpha.5</Version>
+		<Version>1.1.2-alpha.6</Version>
 		<Company>Sense/Net Inc.</Company>
 		<Copyright>Copyright © Sense/Net Inc.</Copyright>
 		<PackageLicenseUrl>https://github.com/SenseNet/sensenet/blob/master/LICENSE</PackageLicenseUrl>
diff --git a/src/Services.Core/SenseNet.Services.Core.csproj b/src/Services.Core/SenseNet.Services.Core.csproj
@@ -2,7 +2,7 @@
 
 	<PropertyGroup>
 		<TargetFramework>net8.0</TargetFramework>
-		<Version>1.1.2-alpha.5</Version>
+		<Version>1.1.2-alpha.6</Version>
 		<Authors>kavics,joe,tusmester,hashtagnulla</Authors>
 		<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
 		<Company>Sense/Net Inc.</Company>
diff --git a/src/Services.Wopi/SenseNet.Services.Wopi.csproj b/src/Services.Wopi/SenseNet.Services.Wopi.csproj
@@ -2,7 +2,7 @@
 
 	<PropertyGroup>
 		<TargetFramework>net8.0</TargetFramework>
-		<Version>1.0.2-alpha.5</Version>
+		<Version>1.0.2-alpha.6</Version>
 		<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
 		<Company>Sense/Net Inc.</Company>
 		<Copyright>Copyright © Sense/Net Inc.</Copyright>
diff --git a/src/Storage/NodeList.cs b/src/Storage/NodeList.cs
@@ -1,11 +1,13 @@
-using System;
-using System.Collections.Generic;
-using System.Text;
-using System.Linq;
+using SenseNet.Client;
+using SenseNet.Configuration;
 using SenseNet.ContentRepository.Storage.Schema;
 using SenseNet.ContentRepository.Storage.Security;
+using SenseNet.Storage.DataModel.Usage;
+using System;
+using System.Collections.Generic;
 using System.Diagnostics;
-using SenseNet.Configuration;
+using System.Linq;
+using System.Text;
 
 namespace SenseNet.ContentRepository.Storage
 {
@@ -561,16 +563,16 @@ internal Q GetSingleValue<Q>() where Q : Node
             if (RawData.Count < 1)
                 return null;
 
-            using var systemAccount = new SystemAccount();
-
-            var user = AccessProvider.Current.GetOriginalUser();
-
             var singleNode = RawData
-                .Select(Node.Load<T>)
+                .Select(nodeId =>
+                {
+                    using var _ = new SystemAccount();
+                    return Node.Load<T>(nodeId);
+                })
                 .Where(node => node != null)
                 .OfType<Q>()
-                .FirstOrDefault(node => 
-                    node.Security.HasPermission(user, PermissionType.See));
+                .FirstOrDefault(node =>
+                    node.Security.HasPermission(PermissionType.See));
 
             return singleNode;
         }
diff --git a/src/Storage/SenseNet.Storage.csproj b/src/Storage/SenseNet.Storage.csproj
@@ -2,7 +2,7 @@
 
 	<PropertyGroup>
 		<TargetFramework>net8.0</TargetFramework>
-		<Version>7.8.2-alpha.5</Version>
+		<Version>7.8.2-alpha.6</Version>
 		<Authors>kavics,tusmester</Authors>
 		<Company>Sense/Net Inc.</Company>
 		<Copyright>Copyright © Sense/Net Inc.</Copyright>
diff --git a/src/Tests/SenseNet.ContentRepository.Tests/NodeTests.cs b/src/Tests/SenseNet.ContentRepository.Tests/NodeTests.cs
@@ -193,6 +193,40 @@ public void Node_Reference_SetReference_Simple_Invisible()
                 Assert.AreEqual(reloaded.Link.Id, target1.Id);
             });
         }
+        [TestMethod, TestCategory("NODE, REFERENCE")] //Fix2202 SystemUser can see always even if the original user not.
+        public void Node_Reference_SetReference_Simple_Invisible_ButSystemUser()
+        {
+            Test(() =>
+            {
+                var root = CreateTestRoot();
+                var u1 = CreateUser("U1");
+                var target0 = new Folder(root) { Name = "folder1" };
+                target0.SaveAsync(CancellationToken.None).GetAwaiter().GetResult();
+                var link = new ContentLink(root) { Name = "Link1", Link = target0 };
+                link.SaveAsync(CancellationToken.None).GetAwaiter().GetResult();
+
+                Providers.Instance.SecurityHandler.CreateAclEditor()
+                    .Allow(link.Id, u1.Id, false, PermissionType.Save)
+                    .ApplyAsync(CancellationToken.None).GetAwaiter().GetResult();
+
+                Assert.IsFalse(target0.Security.HasPermission(u1, PermissionType.See));
+                Assert.IsTrue(link.Security.HasPermission(u1, PermissionType.Save));
+
+                // ACTION
+                Node? loadedLinkForUser;
+                Node? loadedLinkForSystemUser;
+                using (new CurrentUserBlock(u1))
+                {
+                    loadedLinkForUser = link.Link;
+                    using(new SystemAccount())
+                        loadedLinkForSystemUser = link.Link;
+                }
+
+                // ASSERT
+                Assert.IsNull(loadedLinkForUser);
+                Assert.IsNotNull(loadedLinkForSystemUser);
+            });
+        }
 
         [TestMethod, TestCategory("NODE, REFERENCE")] //Fix2202 Deleted reference target can cause nullrefex in the nodelist
         public async STT.Task Node_Reference_GetReference_Single_Deleted()
diff --git a/src/Tests/SenseNet.Tests.Core/SenseNet.Tests.Core.csproj b/src/Tests/SenseNet.Tests.Core/SenseNet.Tests.Core.csproj
@@ -3,7 +3,7 @@
 	<PropertyGroup>
 		<TargetFramework>net8.0</TargetFramework>
 		<IsPackable>true</IsPackable>
-		<Version>1.2.2-alpha.2</Version>
+		<Version>1.2.2-alpha.6</Version>
 		<Authors>kavics,tusmester</Authors>
 		<Company>Sense/Net Inc.</Company>
 		<Copyright>Copyright © Sense/Net Inc.</Copyright>
diff --git a/src/Tools/SnConsoleInstaller/SnConsoleInstaller.csproj b/src/Tools/SnConsoleInstaller/SnConsoleInstaller.csproj
@@ -3,7 +3,7 @@
   <PropertyGroup>
     <OutputType>Exe</OutputType>
     <TargetFramework>net8.0</TargetFramework>
-	  <Version>1.0.1-alpha.4</Version>
+	  <Version>1.0.1-alpha.6</Version>
     <UserSecretsId>99b845c3-2ecb-4630-99c8-f99d7515dae3</UserSecretsId>
   </PropertyGroup>
 
diff --git a/src/WebHooks/SenseNet.WebHooks.csproj b/src/WebHooks/SenseNet.WebHooks.csproj
@@ -2,7 +2,7 @@
 
 	<PropertyGroup>
 		<TargetFramework>net8.0</TargetFramework>
-		<Version>1.1.2-alpha.4</Version>
+		<Version>1.1.2-alpha.6</Version>
 		<Authors>kavics,aniko,tusmester</Authors>
 		<Company>Sense/Net Inc.</Company>
 		<Copyright>Copyright © Sense/Net Inc.</Copyright>
