Use strongly typed enums (#127)

* New strongly typed propertes of the Content: VersioningMode and InheritableVersioningMode.

* ApprovingMode, InheritableApprovingMode

* User.Gender and MaritalStatus

* Fix tests.

* Folder.PreviewEnabled

* Task.Priority

* Task.Status

* Refactor.

* Content.*Date nullable properties.

* Generalize enum transformer methods.

Author: kavics

src/SenseNet.Client.IntegrationTests/ContentTests.cs

@@ -208,14 +208,6 @@ public class File : Content
     {
         public File(IRestCaller restCaller, ILogger<Content> logger) : base(restCaller, logger) { }
 
-        /*TODO: Use enum VersioningType, ApprovingType
-        public enum VersioningType{Inherited, None, MajorOnly, MajorAndMinor}
-        public enum ApprovingType{Inherited, False, True}
-        public VersioningType VersioningMode { get; set; }
-        public ApprovingType ApprovingMode { get; set; }
-        */
-        public string[] VersioningMode { get; set; }
-        public string[] ApprovingMode { get; set; }
         public string Version { get; set; }
         public Binary Binary { get; set; }
     }
@@ -243,8 +235,8 @@ await GetRepositoryCollection(
             };
 
             var file = repository.CreateContent<File>(rootPath, null, fileName);
-            file.VersioningMode = new[] { "3" }; // MajorAndMinor
-            file.ApprovingMode = new[] { "2" }; // True
+            file.VersioningMode = VersioningMode.MajorAndMinor;
+            file.ApprovingMode = ApprovingEnabled.Yes;
             await file.SaveAsync(cancel).ConfigureAwait(false);
             await AssertFileVersion(repository, loadFileRequest, "V0.1.D", cancel);
 
@@ -302,8 +294,8 @@ await GetRepositoryCollection(
                 .GetRepositoryAsync("local", cancel).ConfigureAwait(false);
 
         var file = repository.CreateContent<File>("/Root/Content", null, Guid.NewGuid().ToString());
-        file.VersioningMode = new[] { "0" }; // Inherited
-        file.ApprovingMode = new[] { "0" }; // Inherited
+        file.VersioningMode = VersioningMode.Inherited;
+        file.ApprovingMode = ApprovingEnabled.Inherited;
         await file.SaveAsync(cancel).ConfigureAwait(false);
         var fileId = file.Id;
         var loaded = await repository.LoadContentAsync(fileId, cancel).ConfigureAwait(false);
@@ -346,8 +338,8 @@ await GetRepositoryCollection(
         }
 
         var file = repository.CreateContent<File>(source.Path, null, Guid.NewGuid().ToString());
-        file.VersioningMode = new[] { "0" }; // Inherited
-        file.ApprovingMode = new[] { "0" }; // Inherited
+        file.VersioningMode = VersioningMode.Inherited;
+        file.ApprovingMode = ApprovingEnabled.Inherited;
         await file.SaveAsync(cancel).ConfigureAwait(false);
         var fileId = file.Id;
         var fileText = Guid.NewGuid().ToString();
@@ -393,8 +385,8 @@ await GetRepositoryCollection(
         }
 
         var file = repository.CreateContent<File>(source.Path, null, Guid.NewGuid().ToString());
-        file.VersioningMode = new[] { "0" }; // Inherited
-        file.ApprovingMode = new[] { "0" }; // Inherited
+        file.VersioningMode = VersioningMode.Inherited;
+        file.ApprovingMode = ApprovingEnabled.Inherited;
         await file.SaveAsync(cancel).ConfigureAwait(false);
         var fileId = file.Id;
         var fileText = Guid.NewGuid().ToString();

src/SenseNet.Client.IntegrationTests/UploadDownloadTests.cs

@@ -182,11 +182,6 @@ public class File : Content
     {
         public File(IRestCaller restCaller, ILogger<Content> logger) : base(restCaller, logger) { }
 
-        /*TODO: Use enum VersioningMode
-        public enum VersioningType{Inherited, None, MajorOnly, MajorAndMinor}
-        public VersioningType VersioningMode { get; set; }
-        */
-        public string[] VersioningMode { get; set; }
         public string Version { get; set; }
         public Binary Binary { get; set; }
     }
@@ -311,29 +306,31 @@ await GetRepositoryCollection(
             var loadFileRequest = new LoadContentRequest
             {
                 Path = filePath,
-                Select = new[] { "Id", "Path", "Name", "Type", "Version", "VersioningMode", "Binary" }
+                Select = new[] {"Id", "Path", "Name", "Type", "Version", "VersioningMode", "Binary"}
             };
-            var uploadRequest = new UploadRequest { ParentPath = rootPath, ContentName = fileName };
+            var uploadRequest = new UploadRequest {ParentPath = rootPath, ContentName = fileName};
 
             // Prepare file versions
             var file = repository.CreateContent<File>(rootPath, null, fileName);
-            file.VersioningMode = new[] { "3" }; // MajorAndMinor
+            file.VersioningMode = VersioningMode.MajorAndMinor;
             await file.SaveAsync(cancel).ConfigureAwait(false);
 
             await file.CheckOutAsync(cancel).ConfigureAwait(false); // V0.2.L
 
             await using (var uploadStream = Tools.GenerateStreamFromString("File text 1"))
-                uploadedResult = await repository.UploadAsync(uploadRequest, uploadStream, cancel).ConfigureAwait(false);
+                uploadedResult =
+                    await repository.UploadAsync(uploadRequest, uploadStream, cancel).ConfigureAwait(false);
 
             await file.CheckInAsync(cancel).ConfigureAwait(false); //V0.2.D
 
             await file.CheckOutAsync(cancel).ConfigureAwait(false); // V0.3.L
 
             await using (var uploadStream = Tools.GenerateStreamFromString("File text 2"))
-                uploadedResult = await repository.UploadAsync(uploadRequest, uploadStream, cancel).ConfigureAwait(false);
+                uploadedResult =
+                    await repository.UploadAsync(uploadRequest, uploadStream, cancel).ConfigureAwait(false);
 
             await repository.GetResponseStringAsync(
-                new ODataRequest(repository.Server) { ContentId = file.Id, ActionName = "Publish" }, // V1.0.A
+                new ODataRequest(repository.Server) {ContentId = file.Id, ActionName = "Publish"}, // V1.0.A
                 HttpMethod.Post, cancel).ConfigureAwait(false);
 
             Assert.AreEqual(file.Id, uploadedResult.Id);
@@ -343,7 +340,8 @@ await repository.GetResponseStringAsync(
             await file.CheckOutAsync(cancel).ConfigureAwait(false); // V1.1.L
 
             await using (var uploadStream = Tools.GenerateStreamFromString("File text 3"))
-                uploadedResult = await repository.UploadAsync(uploadRequest, uploadStream, cancel).ConfigureAwait(false);
+                uploadedResult =
+                    await repository.UploadAsync(uploadRequest, uploadStream, cancel).ConfigureAwait(false);
 
             await file.CheckInAsync(cancel).ConfigureAwait(false); //V1.1.D
 
@@ -352,21 +350,21 @@ await repository.GetResponseStringAsync(
             string? lastMajorText = null; // V1.0
             string? file_V0_2Text = null; // V0.2
             await repository.DownloadAsync(
-                request: new DownloadRequest { ContentId = file.Id },
+                request: new DownloadRequest {ContentId = file.Id},
                 responseProcessor: async (stream, _) =>
                 {
                     using var reader = new StreamReader(stream);
                     lastDraftText = await reader.ReadToEndAsync();
                 }, cancel).ConfigureAwait(false);
             await repository.DownloadAsync(
-                request: new DownloadRequest { ContentId = file.Id, Version = "LastMajor" },
+                request: new DownloadRequest {ContentId = file.Id, Version = "LastMajor"},
                 responseProcessor: async (stream, _) =>
                 {
                     using var reader = new StreamReader(stream);
                     lastMajorText = await reader.ReadToEndAsync();
                 }, cancel).ConfigureAwait(false);
             await repository.DownloadAsync(
-                request: new DownloadRequest { ContentId = file.Id, Version = "V0.2" },
+                request: new DownloadRequest {ContentId = file.Id, Version = "V0.2"},
                 responseProcessor: async (stream, _) =>
                 {
                     using var reader = new StreamReader(stream);
@@ -378,6 +376,10 @@ await repository.DownloadAsync(
             Assert.AreEqual("File text 2", lastMajorText);
             Assert.AreEqual("File text 1", file_V0_2Text);
         }
+        catch (Exception e)
+        {
+            var q = 1;
+        }
         finally
         {
             await repository.DeleteContentAsync(filePath, true, cancel);